Callback calling from CommandPalette vs Button

[BongoKnight]

When an app callback function is fired by a Butoon.Pressed event, it seems to be triggered correctly, but this is not the case when this callback is called by a Hit object. This broke in release 0.74.0. Previously this callback was fired by both events.

Version 0.73 :

Version 0.74 :

See bellow an MRE

from textual import on
from textual.app import App, ComposeResult
from textual.command import Hit, Hits, Provider
from textual.screen import Screen
from textual.widgets import Button, Footer

ACTIONS = ["Action"]


class ActionCommands(Provider):
    """A command provider to return all actions for the current text."""

    async def search(self, query: str) -> Hits:
        """Search for action."""
        matcher = self.matcher(query)

        app = self.app
        assert isinstance(app, ClipBrowser)

        for value in ACTIONS:
            score = matcher.match(value)
            if score > 0:
                yield Hit(
                    value,
                    matcher.highlight(value),
                    app.get_param,
                    help=f"Executing {value}",
                )


class ParamScreen(Screen):
    def compose(self) -> ComposeResult:
        yield Button("ParamScreenButton")

    def on_button_pressed(self) -> None:
        self.dismiss(result="worked")


class ClipBrowser(App):
    COMMANDS = {ActionCommands}

    def compose(self) -> ComposeResult:
        yield Button("First button", id="main_button")
        yield Footer()

    def get_param(self):
        param_screen = ParamScreen()
        self.push_screen(param_screen, self.handle_param)

    def handle_param(self, result):
        self.notify(f"It {result}")

    @on(Button.Pressed, "#main_button")
    def execute_option_action(self, event: Button.Pressed) -> None:
        self.get_param()


if __name__ == "__main__":
    cyberClip = ClipBrowser()
    cyberClip.run()

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.