Implement mypy strict flag

[nathanrpage97]

What are your thoughts on implementing Mypy strict flag?

Some of the rich functions currently fail when I use mypy --strict on my own projects. (e.g., console.print isn't fully typed).

I'd be willing to fix the issues that currently exist, but wanted to make sure you think it is worth it first. At least fixing console.print to be fully typed would be a backup proposal.

Here are the logs when I run mypy with the strict flag enabled.

 make typecheck
mypy -p rich --strict
rich/repr.py:13: error: Function is missing a type annotation for one or more arguments
rich/_lru_cache.py:9: error: Missing type parameters for generic type "OrderedDict"
rich/_timer.py:12: error: Function is missing a return type annotation
rich/_emoji_replace.py:8: error: Function is missing a type annotation for one or more arguments
rich/_emoji_replace.py:17: error: Returning Any from function declared to return "str"
rich/_ratio.py:144: error: unused 'type: ignore' comment
rich/__init__.py:33: error: Function is missing a type annotation for one or more arguments
rich/__init__.py:45: error: Function is missing a return type annotation
rich/__init__.py:45: error: Function is missing a type annotation for one or more arguments
rich/__init__.py:69: error: Function is missing a return type annotation
rich/text.py:181: error: Function is missing a type annotation for one or more arguments
rich/text.py:512: error: unused 'type: ignore' comment
rich/text.py:516: error: Redundant cast to "Union[Literal['fold'], Literal['crop'], Literal['ellipsis'], Literal['ignore']]"
rich/text.py:842: error: Function is missing a return type annotation
rich/text.py:871: error: Function is missing a type annotation for one or more arguments
rich/text.py:1018: error: Redundant cast to "Union[Literal['default'], Literal['left'], Literal['center'], Literal['right'], Literal['full']]"
rich/text.py:1019: error: Redundant cast to "Union[Literal['fold'], Literal['crop'], Literal['ellipsis'], Literal['ignore']]"
rich/syntax.py:7: error: Skipping analyzing 'pygments.lexers': found module but no type hints or library stubs
rich/syntax.py:8: error: Skipping analyzing 'pygments.style': found module but no type hints or library stubs
rich/syntax.py:9: error: Skipping analyzing 'pygments.styles': found module but no type hints or library stubs
rich/syntax.py:10: error: Skipping analyzing 'pygments.token': found module but no type hints or library stubs
rich/syntax.py:22: error: Skipping analyzing 'pygments.util': found module but no type hints or library stubs
rich/syntax.py:26: error: Module 'rich.console' does not explicitly export attribute 'Segment'; implicit reexport disabled
rich/style.py:207: error: Returning Any from function declared to return "Style"
rich/style.py:404: error: Returning Any from function declared to return "Style"
rich/style.py:578: error: Returning Any from function declared to return "Style"
rich/style.py:600: error: Returning Any from function declared to return "Style"
rich/style.py:642: error: unused 'type: ignore' comment
rich/style.py:660: error: Returning Any from function declared to return "Style"
rich/segment.py:120: error: Function is missing a type annotation for one or more arguments
rich/scope.py:15: error: Missing type parameters for generic type "Mapping"
rich/scope.py:62: error: Returning Any from function declared to return "ConsoleRenderable"
rich/pretty.py:125: error: Cannot find implementation or library stub for module named 'IPython.core.formatters'
rich/pretty.py:233: error: Implicit generic "Any". Use "typing.DefaultDict" and specify generic parameters
rich/pretty.py:241: error: Missing type parameters for generic type "array"
rich/pretty.py:458: error: Function is missing a type annotation for one or more arguments
rich/pretty.py:624: error: Function is missing a return type annotation
rich/pretty.py:661: error: Function is missing a return type annotation
rich/pretty.py:661: note: Use "-> None" if function does not return a value
rich/panel.py:68: error: Function is missing a return type annotation
rich/panel.py:126: error: unused 'type: ignore' comment
rich/pager.py:23: error: Call to untyped function (unknown) in typed context
rich/measure.py:112: error: Returning Any from function declared to return "Measurement"
rich/markup.py:39: error: Function is missing a type annotation for one or more arguments
rich/markdown.py:3: error: Skipping analyzing 'commonmark.blocks': found module but no type hints or library stubs
rich/markdown.py:8: error: Module 'rich.console' does not explicitly export attribute 'Segment'; implicit reexport disabled
rich/markdown.py:35: error: Function is missing a return type annotation
rich/markdown.py:110: error: Function is missing a type annotation for one or more arguments
rich/jupyter.py:20: error: Function is missing a type annotation
rich/jupyter.py:32: error: Function is missing a type annotation
rich/jupyter.py:72: error: Cannot find implementation or library stub for module named 'IPython.display'
rich/jupyter.py:79: error: Function is missing a type annotation for one or more arguments
rich/control.py:17: error: Missing type parameters for generic type "Callable"
rich/control.py:160: error: Function is missing a type annotation for one or more arguments
rich/containers.py:85: error: Function is missing a type annotation
rich/containers.py:107: error: Function is missing a type annotation for one or more arguments
rich/console.py:148: error: Returning Any from function declared to return "ConsoleOptions"
rich/console.py:292: error: Function is missing a type annotation for one or more arguments
rich/console.py:316: error: Function is missing a type annotation for one or more arguments
rich/console.py:339: error: Function is missing a type annotation for one or more arguments
rich/console.py:389: error: Function is missing a type annotation for one or more arguments
rich/console.py:429: error: Missing type parameters for generic type "Callable"
rich/console.py:436: error: Function is missing a type annotation
rich/console.py:440: error: Function is missing a type annotation
rich/console.py:456: error: unused 'type: ignore' comment
rich/console.py:523: error: Skipping analyzing 'colorama': found module but no type hints or library stubs
rich/console.py:523: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
rich/console.py:776: error: Function is missing a type annotation for one or more arguments
rich/console.py:855: error: Returning Any from function declared to return "bool"
rich/console.py:1120: error: unused 'type: ignore' comment
rich/console.py:1388: error: Function is missing a type annotation for one or more arguments
rich/console.py:1420: error: Function is missing a type annotation for one or more arguments
rich/console.py:1544: error: Function is missing a return type annotation
rich/console.py:1591: error: Function is missing a type annotation for one or more arguments
rich/console.py:1897: error: Function is missing a type annotation for one or more arguments
rich/color.py:307: error: Function is missing a type annotation for one or more arguments
rich/color.py:474: error: Non-overlapping equality check (left operand type: "ColorType", right operand type: "ColorSystem")
rich/align.py:195: error: Function is missing a type annotation for one or more arguments
rich/align.py:267: error: Function is missing a type annotation for one or more arguments
rich/__main__.py:91: error: Function is missing a type annotation for one or more arguments
rich/traceback.py:11: error: Skipping analyzing 'pygments.lexers': found module but no type hints or library stubs
rich/traceback.py:12: error: Skipping analyzing 'pygments.token': found module but no type hints or library stubs
rich/traceback.py:50: error: Missing type parameters for generic type "Callable"
rich/traceback.py:91: error: Function is missing a type annotation for one or more arguments
rich/traceback.py:95: error: Function is missing a type annotation for one or more arguments
rich/traceback.py:101: error: Function is missing a type annotation for one or more arguments
rich/traceback.py:237: error: Missing type parameters for generic type "Type"
rich/traceback.py:596: error: Function is missing a type annotation
rich/traceback.py:600: error: Function is missing a type annotation
rich/traceback.py:611: error: Call to untyped function "bar" in typed context
rich/traceback.py:613: error: Function is missing a return type annotation
rich/traceback.py:613: note: Use "-> None" if function does not return a value
rich/traceback.py:617: error: Call to untyped function "foo" in typed context
rich/traceback.py:623: error: Call to untyped function "error" in typed context
rich/ansi.py:211: error: Function is missing a type annotation
rich/_inspect.py:81: error: Returning Any from function declared to return "Panel"
rich/live.py:103: error: Function is missing a type annotation for one or more arguments
rich/live.py:117: error: Call to untyped function "_enable_redirect_io" in typed context
rich/live.py:141: error: Call to untyped function "_disable_redirect_io" in typed context
rich/live.py:166: error: Function is missing a type annotation for one or more arguments
rich/live.py:169: error: Function is missing a return type annotation
rich/live.py:169: note: Use "-> None" if function does not return a value
rich/live.py:172: error: unused 'type: ignore' comment
rich/live.py:174: error: Incompatible types in assignment (expression has type "FileProxy", variable has type "TextIO")
rich/live.py:175: error: unused 'type: ignore' comment
rich/live.py:177: error: Incompatible types in assignment (expression has type "FileProxy", variable has type "TextIO")
rich/live.py:179: error: Function is missing a return type annotation
rich/live.py:179: note: Use "-> None" if function does not return a value
rich/live.py:182: error: Incompatible types in assignment (expression has type "IO[str]", variable has type "TextIO")
rich/live.py:185: error: Incompatible types in assignment (expression has type "IO[str]", variable has type "TextIO")
rich/live.py:216: error: Cannot find implementation or library stub for module named 'IPython.display'
rich/live.py:217: error: Cannot find implementation or library stub for module named 'ipywidgets'
rich/spinner.py:14: error: Function is missing a type annotation for one or more arguments
rich/status.py:60: error: Function is missing a return type annotation
rich/status.py:104: error: Function is missing a type annotation for one or more arguments
rich/tree.py:23: error: Function is missing a type annotation for one or more arguments
rich/tree.py:39: error: Function is missing a type annotation for one or more arguments
rich/tabulate.py:13: error: Missing type parameters for generic type "Mapping"
rich/prompt.py:238: error: Returning Any from function declared to return "PromptType"
rich/logging.py:250: error: Function is missing a return type annotation
rich/logging.py:250: note: Use "-> None" if function does not return a value
rich/logging.py:260: error: Call to untyped function "divide" in typed context
rich/progress.py:78: error: Function is missing a type annotation for one or more arguments
rich/progress.py:83: error: Function is missing a type annotation for one or more arguments
rich/progress.py:174: error: unused 'type: ignore' comment
rich/progress.py:236: error: Function is missing a return type annotation
rich/progress.py:587: error: unused 'type: ignore' comment
rich/progress.py:652: error: Function is missing a type annotation for one or more arguments
rich/progress.py:655: error: Function is missing a type annotation for one or more arguments
rich/layout.py:225: error: Function is missing a type annotation for one or more arguments
rich/layout.py:415: error: unused 'type: ignore' comment
Found 125 errors in 36 files (checked 73 source files)
make: *** [typecheck] Error 1

[willmcgugan]

There's little benefit in fixing most of those errors. And you may end up littering the code with "type: ignore" to fix them.

However, if you are prepared to do the work, I'm sure I could maintain the strict level going forward...