Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor logo uniform sizes #30

Open
rocketeerbkw opened this issue Aug 28, 2019 · 5 comments
Open

Sponsor logo uniform sizes #30

rocketeerbkw opened this issue Aug 28, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@rocketeerbkw
Copy link
Member

The logos on the sponsor page are coded with flexbox and will try to look as uniform in size as possible. It can still happen that a logo shorter than others, when it's on it's own row looks smaller.

Would be great to fix this with maybe a min-height? Or some other flexbox magic? Maybe related: #22

image

@rocketeerbkw
Copy link
Member Author

Or we can just continue to photoshop the short logos to be taller, like was done for flashpoint

@rocketeerbkw
Copy link
Member Author

Also, if we do the min-height thing, only the logo itself is hyperlinked, not the entire background which is a pet peeve of mine and would be great to fix. See the current fireroad digital as an example.

rocketeerbkw added a commit that referenced this issue Aug 30, 2019
rocketeerbkw added a commit that referenced this issue Aug 30, 2019
@rocketeerbkw
Copy link
Member Author

I adjusted the styles so the logos don't look so cramped, and the hyperlink is now the entire size of the box. But all boxes are still not the same height. Not sure how to do that with flexbox, might require css grids. Or photoshop the images like previously mentioned.

@rocketeerbkw
Copy link
Member Author

image

@ccjjmartin
Copy link
Contributor

For now I manually fixed the Adcetera logo, leaving this open for future logos.

@ccjjmartin ccjjmartin added the enhancement New feature or request label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants