Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proxy for all ports of a domain #1552

Closed
RacingTadpole opened this issue May 19, 2016 · 3 comments
Closed

Allow proxy for all ports of a domain #1552

RacingTadpole opened this issue May 19, 2016 · 3 comments

Comments

@RacingTadpole
Copy link
Contributor

Currently if csiro.au is present in serverconfig.json's allowProxyFor, all domains ending in csiro.au can be proxied... but if an explicit port is appended (eg. ...csiro.au:80), it is not.
Is there a reason for this?

@kring
Copy link
Member

kring commented May 19, 2016

csiro.au:80 won't match unless the port is explicitly included in the URL. i.e. it's not smart, it doesn't know that 80 is the default. But if the port is included, I believe it will match *.csiro.au:80. Is that not what you're seeing?

@RacingTadpole
Copy link
Contributor Author

Yes, but I'm suggesting we make csiro.au also match csiro.au:* (ie. not just 80 but also 8000, etc).

@kring
Copy link
Member

kring commented May 19, 2016

Steve made the same suggestion the other day. See discussion here:
TerriaJS/terriajs-server#13

And perhaps close this issue in favor of that one, because this is really a server issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants