Skip to content

Commit fabfcf6

Browse files
committed
Declare fields as final
1 parent f220f96 commit fabfcf6

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

example/lib/isolate.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,15 @@ class MyHomePage extends StatefulWidget {
3131
}
3232

3333
class FakeTerminalBackend extends TerminalBackend {
34-
Completer<int> _exitCodeCompleter = Completer<int>();
34+
final _exitCodeCompleter = Completer<int>();
3535
// ignore: close_sinks
36-
StreamController<String> _outStream = StreamController<String>();
36+
final _outStream = StreamController<String>();
3737

3838
@override
3939
Future<int> get exitCode => _exitCodeCompleter.future;
4040

4141
@override
4242
void init() {
43-
_exitCodeCompleter = Completer<int>();
44-
_outStream = StreamController<String>();
4543
_outStream.sink.add('xterm.dart demo');
4644
_outStream.sink.add('\r\n');
4745
_outStream.sink.add('\$ ');
@@ -88,7 +86,7 @@ class FakeTerminalBackend extends TerminalBackend {
8886
}
8987

9088
class _MyHomePageState extends State<MyHomePage> {
91-
TerminalIsolate terminal = TerminalIsolate(
89+
final terminal = TerminalIsolate(
9290
backend: FakeTerminalBackend(),
9391
maxLines: 10000,
9492
);

example/lib/main.dart

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ class MyHomePage extends StatefulWidget {
3030
}
3131

3232
class FakeTerminalBackend extends TerminalBackend {
33-
Completer<int> _exitCodeCompleter = Completer<int>();
33+
final _exitCodeCompleter = Completer<int>();
3434
// ignore: close_sinks
35-
StreamController<String> _outStream = StreamController<String>();
35+
final _outStream = StreamController<String>();
3636

3737
@override
3838
Future<int> get exitCode => _exitCodeCompleter.future;
@@ -85,16 +85,11 @@ class FakeTerminalBackend extends TerminalBackend {
8585
}
8686

8787
class _MyHomePageState extends State<MyHomePage> {
88-
Terminal terminal = Terminal(
88+
final terminal = Terminal(
8989
backend: FakeTerminalBackend(),
9090
maxLines: 10000,
9191
);
9292

93-
@override
94-
void initState() {
95-
super.initState();
96-
}
97-
9893
void onInput(String input) {}
9994

10095
@override

0 commit comments

Comments
 (0)