Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voltron): add voltron_screen_info to make flutter_module faster #3541

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

henryjin0511
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service
Copy link

hippy-service bot commented Oct 9, 2023

Hi, @henryjin0511. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

lvfen
lvfen previously approved these changes Oct 9, 2023
zealotchen0
zealotchen0 previously approved these changes Nov 10, 2023
@lvfen lvfen added the action(squash-merge) Squash and merge action label Nov 10, 2023
skindhu
skindhu previously approved these changes Nov 10, 2023
Copy link

hippy-actions bot commented Nov 10, 2023

⚠️ squash-merge action execution failed, because of pull request title does not meet the Convention Commit guideline.

Please check the following details:

⧗   input: Feat/fast flutter module
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   header subject cannot be empty [function-rules/header-min-length]
✖   scope may not be empty [scope-empty]

✖   found 4 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@lvfen

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Nov 10, 2023
lvfen
lvfen previously approved these changes Nov 10, 2023
@henryjin0511 henryjin0511 force-pushed the feat/fast-flutter-module branch from a54588d to 2ef4684 Compare November 14, 2023 07:01
@henryjin0511 henryjin0511 changed the title Feat/fast flutter module feat(voltron): add voltron_screen_info to make flutter_module faster Nov 14, 2023
@zealotchen0 zealotchen0 merged commit 5abd5ad into Tencent:main Nov 14, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action(squash-merge): failed Squash and merge action execution failed doc: example framework: voltron gh: owner renderer: voltron size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants