Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayCardGradient token #1701

Closed
5 of 8 tasks
aweell opened this issue Mar 12, 2024 · 2 comments · Fixed by #1713 or #1718
Closed
5 of 8 tasks

displayCardGradient token #1701

aweell opened this issue Mar 12, 2024 · 2 comments · Fixed by #1713 or #1718

Comments

@aweell
Copy link
Collaborator

aweell commented Mar 12, 2024

Description

With the new brand definition O2 will start using a different colors in the display card gradients. In order to keep the definition i all brands but o2 we need to tokenize the gradient.

The current definition:

linear-gradient(180deg, rgba(0, 0, 0, 0) 0%, rgba(0, 0, 0, 0.4) 29.02%, rgba(0, 0, 0, 0.7) 100%)

The new o2 definition (WIP in #1689):

linear-gradient(180deg, rgba(0, 80, 255, 0) 0%, rgba(0, 80, 255, 0.6) 29.02%, rgba(0, 80, 255, 1) 100%)

With the new gradient definition:

"cardContentOverlay": {
    "type": "linear-gradient",
    "value": {
        "angle": 180,
        "colors": [
            {"value": "rgba({palette.beyondBlue}, 0)", "stop": 0},
            {"value": "rgba({palette.beyondBlue}, 0.4)", "stop": 0.3},
            {"value": "rgba({palette.beyondBlue}, 0.7)", "stop": 1},
        ],
    },
    "description": "beyondBlue"
},

Tasks

@yceballost
Copy link
Collaborator

0.29 could be 0.3 to round this number...? 😬

@aweell
Copy link
Collaborator Author

aweell commented Mar 12, 2024

Yes, i donno why is 29.02% in production

@aweell aweell reopened this Mar 26, 2024
@aweell aweell self-assigned this Mar 26, 2024
@aweell aweell added this to the 13.0.0 milestone Mar 26, 2024
@aweell aweell linked a pull request Mar 27, 2024 that will close this issue
@aweell aweell closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment