-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Business site project - Jenny Andersén #374
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jenny, great job with your business site! 🎬🍿 You’ve done an excellent job incorporating a video background and a clean and user-friendly form. Some feedback coming up 👀
HTML
- You’ve done a good job with the video background. The autoplay, loop, muted, and playsinline attributes are well-used and the overlay-text over the video is well-positioned.
- Your form is well-structured and includes a variety of input types ✅ Don't forget to label all inputs though! When you submit your form, you see that the whole summary is not there (just the radio buttons).
- Clever to only show the video on larger screens. Consider adding a fallback text for browsers or connections that may not support video playback as well.
CSS
- Your page looks very clean and nice! It would be nice to add some more guidance for the user with the help of e.g. hover effect on the button.
Changes requested
- Update your labels so that the summary is accurate
Overall, this looks super, so keep up the good work! 🎉👏
Thanks so much for your feedback @HIPPIEKICK 😊 have now added labels to the form! ✅ |
Business site project. Practicing HTML forms.
Live link:
https://binge-streaming-business-site.netlify.app/