Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Refactor FB & Google login flow to prevent the jwt token to be sent as a query parameter #108

Open
fernanri opened this issue Mar 25, 2020 · 0 comments

Comments

@fernanri
Copy link
Contributor

fernanri commented Mar 25, 2020

The current FB login flow is being made in the backend side and the resultant jwt token is then being transmitted to the frontend as a query parameter in a redirect call. This makes the jwt token to be leaked in the server logs. (at least) which is not optimal.

The proposal is to perform the full oAuth authentication flow, where the client (frontend) asks for the FB token and then calls an API method with that token. The API should then use the token to fetch the information needed and return a JWT token in the reply.

@fernanri fernanri changed the title Refactor FB login flow to prevent jet token to be sent as a query parameter Refactor FB login flow to prevent the jwt token to be sent as a query parameter Mar 25, 2020
@pfortuna pfortuna changed the title Refactor FB login flow to prevent the jwt token to be sent as a query parameter [backend] Refactor FB login flow to prevent the jwt token to be sent as a query parameter Mar 25, 2020
@carlospombeiro carlospombeiro changed the title [backend] Refactor FB login flow to prevent the jwt token to be sent as a query parameter [backend] Refactor FB & Google login flow to prevent the jwt token to be sent as a query parameter Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant