Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Measure Command] Respect noteskin sButton measurement #26

Open
moruzerinho6 opened this issue Jun 29, 2022 · 0 comments
Open

[Measure Command] Respect noteskin sButton measurement #26

moruzerinho6 opened this issue Jun 29, 2022 · 0 comments
Assignees
@moruzerinho6
Labels
Needs planning This feature still needs planning for prototype Update Command This means a command requires a update.

Comments

@moruzerinho6
Copy link
Member

Currently, when dealing with holdBody/rollBody, we request the tapNote measurement and use that to scale, while this is good enough for most modes, it limits noteskin, GH modern-2d makes use of holds that have smaller width than the noteskin (same for SMX)
@moruzerinho6 moruzerinho6 added the Prototype ready Working examples already done label Jun 29, 2022
@moruzerinho6 moruzerinho6 self-assigned this Jun 29, 2022
@moruzerinho6 moruzerinho6 added Needs planning This feature still needs planning for prototype Update Command This means a command requires a update. and removed Prototype ready Working examples already done labels Sep 18, 2022
@moruzerinho6 moruzerinho6 changed the title [Measure Branch] Respect noteskin sButton measurement [Measure Command] Respect noteskin sButton measurement Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moruzerinho6 moruzerinho6

Labels
Needs planning This feature still needs planning for prototype Update Command This means a command requires a update.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moruzerinho6