-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign - EFY #1391
Comments
The code for it can be found at the |
On my list already! Thanks! |
@Senor-Ducky It got broken after the last commit, it was okay before, but I think I identified the cause for the most part. Thank you! If you notice other bugs lmk |
The live instance will likely have issues for a while, but the css code is fine, it's just needs to be split and distributed to vue components. Keep sending feedback, but keep in mind that there might be a difference between how unstable it seems to be and how stable it actually is |
@IronMaltese Glad you like it! Your issue was on the list too, but having it here makes it easier to keep track of what I gotta do lol, so thanks! |
Everyone and @Senor-Ducky , if you tried the live instance before the problem got fixed, try clearing your cache ( |
Fixed all the issues above, refresh your cache if needed! |
The Text is too big in 'Select a Playlist' modal. Would be better if it is smaller. |
|
The animation which plays on click is extremely distracting. There should be a way to disable it. |
fixed in the new update. I'll look into the rounded corners for the video and polish characters. Thanks for the feedback!! |
@EdwardLangdon thanks again! I'll look into all of them. For the shorts tho, I think it could be the main colours rather than red, so that it fits with whatever colours the user chooses and instead of black, the variable for the background, like the time on the video, which can be black, white, chosen by the user etc. So basically kinda the same as your idea, but with custom colors |
Alright @opl- , I can add a new accessibility option for that then. I need to figure out how to implement it, but it should be fairly easy I think. Thank you! To make sure I fully understand you, do you mean buttons or any animation related to clicks in general? |
The main thing for me was the scale down -> scale back up "pulse" animation playing whenever I clicked on any button, video or any other interactive element. |
@opl- Alright, got you then |
@opl- There will be a toggle inside |
@martin-desktops Thanks again! We're planning to make a module in the sidebar for captions, so that you can choose between multiple styles, like maybe (not decided yet), you can choose between background, no background and blurred. Right now I'm trying to solve issues that get the framework and redesign to a stable state and then things like captions or comments can become more modular and doing that should take less time. I'm pretty limited time wise by having to apply to jobs, which is why things have been slower, but I acknowledge the current problem with captions or other similar bugs, like the white flash on page load. Keep the feedback going when you need to! Will take care of this as soon as I can! Btw, I can't replicate your bug with Polish characters, so please let me know how I can if it's still present. |
Just out of curiosity. Is https://piped.mha.fi the same redesign as this development thread ? |
@kzhe2059 If you mean changing the backend instance, then go to |
Yes, but you can only choose from the list, not input custom url for the api and such |
Hey @Reinachan! Yeah, it's the right place.
Thanks for the feedback, feel free to give me more whenever you feel the need to, it helps me and the community overall have a better experience! Just keep in mind that my time for Piped is limited currently cuz of other priorities, but soon I'll work on more stuff |
@kzhe2059 that's not related to efy then... cuz the official piped doesn't have that feature either, so I guess maybe talk to the main devs about it IF THEY LIKE THE IDEA, else it won't be added in the efy version either, since I'd have to rely on the defaults, which I'm not responsible for. |
Hello! I noticed that there is no share video button. Is that planned to be added? |
@Imzxhir yes, it's a bug I'll fix soon, it should be easy, it annoys me too, as someone who copies links a lot haha |
how can i install this locally? Is there documentation for install or a docker compose? |
@athiosh You can run it locally if you clone it and switch to the efy branch, or we have a docker tutorial on the efy site: 1. LocalClone it from github:
To run it first install packages with:
And then you can use either
or
In the terminal you'll see the link you gotta navigate to in your browser 2. DockerFollow the tutorial at https://efy.ooo/#faq#piped_instance Now that you mentioned it, maybe I should add the 1st method to the docs as well when I get some spare time 🤔 |
@Imzxhir forgot to reply here, but the bug seems to be caused by uBlock Origin, so if you have it on, try turning it off only for piped or changing your configuration maybe, that worked for me and other people I've been talking to. I'm still looking for other methods tho, but to keep you updated on it |
@dragos-efy thank you for the documentation. Awesome work. |
@athiosh so wait, to confirm, does it work now after doing that? And no worries, glad to help! |
@codenyte cool! I added it to the project's tasks |
@dragos-efy , it only works if the browser is cached with my login session. If I wasn't login prior to running the efy image it will be blank like the screenshot I shared. I hope this make sense. |
@athiosh thanks 🤟 it makes sense, yeah, I wanted to be sure I fully get you & I added it to the tasks, but keep in mind that I'm an absolute noob at docker and I have other priorities to work on, so unless someone else finds a fix, it will probably take me a while to dig deeper into it. I'm glad you mentioned it tho, hopefully we'll find a solution |
@dragos-efy I've spent sometime today trying to figure out what is causing the issue and after reading the error carefully it shows that page failed to construct the URL, so after some more investigation I was able to make the page load after adding instance and auth_instance_url variable in the local storage in the browser. Once those two value is populated, everything worked. The first screenshot is the current state where those variable is not populated on start. The second screenshot is where I have manually enter the variable, ignore the authtoken as it generate after login. I hope this would help in fixing the issue. |
@athiosh I think that the auth variables are a pretty significant clue for sure! Thanks for the info & screenshots 👏 |
@athiosh well I can't test it rn cuz all public instances are blocked by yt. Are you doing that on a private instance? Or are some instances working that I'm not aware of? |
yea, i am hosting it privately using docker. |
That or you navigate to https://piped_instance.example.com/preferences and set the custom instance there. Is there a way to set or build EFY with a default instance? |
@dragos-efy , I had some time yesterday and decided to take a stab at this. The issues seems to be the Dockerfile not getting the .env file during build, I just hardcoded it inside the Dockerfile after the WORKDIR /app/ line and it worked after.
|
@vayan the efy branch is the same as main but with some changes to the vue components + adding the efy package so that those components apply the changes related to efy visually, so the answer is YES, you just modify parts to be compatible, which is what we've been doing all this time. I haven't gotten a lot of time for it lately tho and the problem is that since the efy branch is not the official one, there's always a TON of files that need to be modified to keep up and have stuff updated, so it's quite time consuming and annoying to do all of that regularly, which is why I proposed to either make efy the default or just have efy as a different thing that is independent from the main branch, cuz it's just frustrating to manage it all as mainly a 1 person activity who has over 20 other projects to work on as well apart from this. Short answer, you can modify the config files or vue files directly and the build that and it should work, it's just a bit time consuming to solve all the mini errors that show up when you try to do that, but the process itself is kinda easy |
@athiosh that's coooooool 🔥 Thanks for sharing, I bet that some lurkers who don't comment publicly but look for solutions will find this useful too haha 👀 |
@dragos-efy , one thing left to fix is the caption. The page will crash everytime i enable caption in chromium based browser on my macbook however every other browser like Safari and firefox will work fine even chromium base ios browser has no issue either. Do you have any thoughts on what might cause the issue? |
@athiosh no clue, maybe try turning off extensions, or try chromium on linux / windows to see if it's the same, then if it's the same on those it's probably chromium related, if not, then mac related. Chromium on ios uses webkit anyway, not v8, so it's not really the same chromium as on linux, windows, mac, etc, therefore it's kinda like testing on safari, so it doesn't count |
Here's the new Piped redesign! 🥳 It uses efy for customisation features and to help you theme it how you want. It's not just simple predetermined themes, you can actually create billions of patterns & themes yourself or import them from others.
You can track the current status of the features, ideas & bugs here. I'm also working on the documentation to make it easier for devs to understand the logic behind it and contribute. Any feedback or suggestions you have, please share them, I and other really cool people who I'm grateful for have been testing it, but bugs can still come up, therefore if you wanna share something, please do!
Live demo: https://efy.piped.pages.dev
Matrix room for questions and support specific to efy: https://matrix.to/#/#efy_ui:matrix.org
Features
Special thanks to: Bnyro, Kavin, Zucc (whatever.social), Diamond_AaronXG, IkelAtomig and other small or anonymous contributors, you guys rock! 🔥
The text was updated successfully, but these errors were encountered: