Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found functionality that requires fixing #164

Open
mdziczkowski opened this issue Jan 3, 2024 · 2 comments
Open

Found functionality that requires fixing #164

mdziczkowski opened this issue Jan 3, 2024 · 2 comments

Comments

@mdziczkowski
Copy link

mdziczkowski commented Jan 3, 2024

hey, I had noticed things to fix in Amaze utilities:

  1. settings:
  • instead of separatelly set the include path for every setting (with is annoying), create a global option

  • in the function to add "included folders", not all folders in the directory tree are shown

  • analyse functions should scan recrusivelly the folders given in the "include path"

  • there should be possible to select whole device storage path (starting from "/" ) and not only from user home directory

  1. Analyse:

Many analyse functionality in it doesn't work as it should. Example: cleaning up

  • it show how much storage or memory is used, but it doesn't free it

  • by space taken by applications, instead of clear it cache, etc. it ask to uninstall the application

  1. Recovery utility

Please add a recovery functionality because your tool has removed too much (it was not listed what exactly will be removed before the "clean-up")

@VishalNehra
Copy link
Member

  1. setting:
    global option for paths for every setting -> agreed
    please explain 'included functions' issue, maybe with a video?
    we can't scan recursively in directories as it'll be too slow. We use media store and identify if the path of mediastore file contains the path selected by the user, ideally - it should behave like a recursive scan itself.
    Providing an option to select whole device storage -> agreed (although it'll be a bit slow, but a warning message should suffice).

  2. analyse:
    the amount of the memory shown is the amount of memory that'll be freed (if you delete the files permanently).
    can't clean other apps' cache (restricted by android filesystem).

  3. recovery utility:
    ideally, that's what trash bin is supposed to be. I guess by the time you raised this issue the trash bin wasn't implemented. So, if you cleaned up storage temporarily you should be able to go to trash bin and recover the files. But once permanently deleted, they can't be recovered.

All the agreed functions will be implemented in new version, thanks for your observations :)

@mdziczkowski
Copy link
Author

please explain 'included functions' issue, maybe with a video?

You had missread it. I wrote:

In the function to add included folders

and not "included functions"

we can't scan recursively in directories as it'll be too slow. We use media store and identify if the path of mediastore file contains the path selected by the user, ideally - it should behave like a recursive scan itself.

Please take into attention that not on every device it's correctly implemented, so basing only on it it's not the best option

can't clean other apps' cache (restricted by android filesystem).

Strange, many software for Android (including the archive manager 7zip) already offer such possibility (however, it isn't implemented in the best way), then why your software can't do it?

Additionally, all cleaning functionality should be run with elevated privileges to ensure that the cleaning realy happens instead of pretending of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants