Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash Checker for files transferred #121

Open
shuvashish76 opened this issue Aug 19, 2023 · 5 comments
Open

Hash Checker for files transferred #121

shuvashish76 opened this issue Aug 19, 2023 · 5 comments

Comments

@shuvashish76
Copy link

Feature request for hash checker integration.
https://github.com/hash-checker/hash-checker is probably the best foss alternative.

@VishalNehra
Copy link
Member

I don't see how we can integrate this feature in this app. It's not related to files. This utilities app is focused on dealing with files, saving memory and media players.
I think we shouldn't clutter with features not relevant.

@shuvashish76 shuvashish76 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2023
@shuvashish76
Copy link
Author

The utilities app is focused on dealing with files.

Sometimes file corruption happens while sending big size files/backups to another device/PC, this feature helps for that purpose.

@VishnuSanal
Copy link
Member

The utilities app is focused on dealing with files.

Sometimes file corruption happens while sending big size files/backups to another device/PC, this feature helps for that purpose.

Agreed for the purpose; but the mentioned repository is not a library but an actual implementation of the concept.

In the case of AFU, we should implement it from scratch. As Vishal mentioned, this is not on the priorities in the roadmap for AFU's development. Keeping this issue open as it is open for contributions!

@VishnuSanal VishnuSanal reopened this Aug 19, 2023
@shuvashish76
Copy link
Author

mentioned repository is not a library but an actual implementation

Mentioned that here because the method they used works for very big size files (link)
Thanks 👍🏿

@VishalNehra
Copy link
Member

The utilities app is focused on dealing with files.

Sometimes file corruption happens while sending big size files/backups to another device/PC, this feature helps for that purpose.

We already have a hashing function to identify duplicate files. We can introduce hashing at the end of transfer to validate the file is correctly sent. That's not a problem. However introducing multiple hashing functions, or allowing user to generate hashes isn't really relevant here.

@VishalNehra VishalNehra changed the title Hash Checker Hash Checker for files transferred Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants