v3.10 breaks SSH connections

[Fmstrat]

Describe the bug
When using SSH connections, either the system can't validate the host key, or the second folder deep shows no files.

To Reproduce
Problem 1:
Steps to reproduce the behavior:

1. Connect to SSH server connection that goes direct to a path like /storage
2. Get list of folders
3. Choose any sub folder
4. No files are displayed

Problem 2:

1. Connect to another SSH server
2. Get:

ComposedException 1 :
	net.schmizz.sshj.transport.TransportException: [HOST_KEY_NOT_VERIFIABLE] Could not verify `ssh-ed25519` host key with fingerprint `...` for `...com` on port 1028

Expected behavior
Functional SSH with existing connections after upgrade

Smartphone (please complete the following information):

• Device: S9 Pro tablet
• OS: Android 14
• Rooted: no
• Version: 3.10

[VishalNehra]

@TranceLove

[Fmstrat]

Any news on this? Trying to hold off on Google updates since this breaks a primary use case. Thanks!

[TranceLove]

Short answer: #4101 to the fix.

Longer answer: #4101 seems fix the problem, but this is to revert the change we did before to make other things work. Still running the regressions when I'm free, but not very satisfying. So I think for the time being the best workaround would be refrain from using SSH connections with default path to open, i.e. just browse from the root.

Even longer answer: deep down the classes, the culprit was the way lookup the connection parameters and connection instance from the connection pool, when the connection string in database has default path to open included, e.g.

ssh://[email protected]:22222/home/user

When the user opens /home/user/subfolder, current codebase has problem looking up connection with ssh://[email protected]:22222/home/user/subfolder.

I'm seeing some refactoring required to accommodate this, like separating the base URI and default path, so code can always lookup the connection using ssh://[email protected]:22222.

Otherwise, as a band-it solution, we deduct the path elements one by one, and try to match the connection string with database and connection pool until there is one; but this is inefficient and IMO not a good approach.

On the other hand, we may just drop the connection pool and use singletons to store the SSH/FTP connections instead. We have only 2 tabs, and perhaps 90% usecases we are copying files between device and remote server, but not between remote servers, so this might work as well. But this is refactoring equally expensive as the above "split URI to base path and default path" method.

[Fmstrat]

Thank you! The default path info is helpful as that allows me to upgrade, too.

[Fmstrat]

Note: I have 2 connections to two different servers running the same version of OpenSSH and using the exact same config with no default path.

One works, one doesnt.

If I can provide any debug info, let me know.

[Fmstrat]

I have also learned in trying to work around problem 1 that I cannot create a connection without a password and just a private key. The create button is grayed out.