From 3e13154e98474c6decdfc5d3440661fadeb7baaf Mon Sep 17 00:00:00 2001
From: Patrick Fairbank <patfair@gmail.com>
Date: Wed, 4 Oct 2023 17:27:04 -0700
Subject: [PATCH] Get rid of unused 'Signal Volunteers' button.

---
 field/arena.go               |  2 --
 static/css/referee_panel.css |  3 ---
 static/js/match_play.js      | 10 ----------
 static/js/referee_panel.js   |  5 -----
 templates/match_play.html    |  4 ----
 templates/referee_panel.html |  1 -
 web/match_play.go            |  7 -------
 web/referee_panel.go         |  6 ------
 8 files changed, 38 deletions(-)

diff --git a/field/arena.go b/field/arena.go
index 7908ca20..75320271 100644
--- a/field/arena.go
+++ b/field/arena.go
@@ -67,7 +67,6 @@ type Arena struct {
 	lastDsPacketTime           time.Time
 	lastPeriodicTaskTime       time.Time
 	EventStatus                EventStatus
-	FieldVolunteers            bool
 	FieldReset                 bool
 	AudienceDisplayMode        string
 	SavedMatch                 *model.Match
@@ -252,7 +251,6 @@ func (arena *Arena) LoadMatch(match *model.Match) error {
 	arena.soundsPlayed = make(map[*game.MatchSound]struct{})
 	arena.RedRealtimeScore = NewRealtimeScore()
 	arena.BlueRealtimeScore = NewRealtimeScore()
-	arena.FieldVolunteers = false
 	arena.FieldReset = false
 	arena.ScoringPanelRegistry.resetScoreCommitted()
 	arena.Plc.ResetMatch()
diff --git a/static/css/referee_panel.css b/static/css/referee_panel.css
index 9489b07a..5aa18c73 100644
--- a/static/css/referee_panel.css
+++ b/static/css/referee_panel.css
@@ -177,9 +177,6 @@ h3 {
 .control-button[data-enabled=true] {
   opacity: 1;
 }
-#volunteerButton {
-  background-color: #90c;
-}
 #resetButton {
   background-color: #093;
 }
diff --git a/static/js/match_play.js b/static/js/match_play.js
index 90f45c89..4bd52f2b 100644
--- a/static/js/match_play.js
+++ b/static/js/match_play.js
@@ -39,11 +39,6 @@ const abortMatch = function() {
   websocket.send("abortMatch");
 };
 
-// Sends a websocket message to signal to the volunteers that they may enter the field.
-const signalVolunteers = function() {
-  websocket.send("signalVolunteers");
-};
-
 // Sends a websocket message to signal to the teams that they may enter the field.
 const signalReset = function() {
   websocket.send("signalReset");
@@ -158,7 +153,6 @@ const handleArenaStatus = function(data) {
     case "PRE_MATCH":
       $("#startMatch").prop("disabled", !data.CanStartMatch);
       $("#abortMatch").prop("disabled", true);
-      $("#signalVolunteers").prop("disabled", false);
       $("#signalReset").prop("disabled", false);
       $("#fieldResetRadio").prop("disabled", false);
       $("#commitResults").prop("disabled", true);
@@ -173,7 +167,6 @@ const handleArenaStatus = function(data) {
     case "TELEOP_PERIOD":
       $("#startMatch").prop("disabled", true);
       $("#abortMatch").prop("disabled", false);
-      $("#signalVolunteers").prop("disabled", true);
       $("#signalReset").prop("disabled", true);
       $("#fieldResetRadio").prop("disabled", true);
       $("#commitResults").prop("disabled", true);
@@ -184,7 +177,6 @@ const handleArenaStatus = function(data) {
     case "POST_MATCH":
       $("#startMatch").prop("disabled", true);
       $("#abortMatch").prop("disabled", true);
-      $("#signalVolunteers").prop("disabled", false);
       $("#signalReset").prop("disabled", false);
       $("#fieldResetRadio").prop("disabled", false);
       $("#commitResults").prop("disabled", false);
@@ -195,7 +187,6 @@ const handleArenaStatus = function(data) {
     case "TIMEOUT_ACTIVE":
       $("#startMatch").prop("disabled", true);
       $("#abortMatch").prop("disabled", false);
-      $("#signalVolunteers").prop("disabled", true);
       $("#signalReset").prop("disabled", true);
       $("#fieldResetRadio").prop("disabled", false);
       $("#commitResults").prop("disabled", true);
@@ -206,7 +197,6 @@ const handleArenaStatus = function(data) {
     case "POST_TIMEOUT":
       $("#startMatch").prop("disabled", true);
       $("#abortMatch").prop("disabled", true);
-      $("#signalVolunteers").prop("disabled", true);
       $("#signalReset").prop("disabled", true);
       $("#fieldResetRadio").prop("disabled", false);
       $("#commitResults").prop("disabled", true);
diff --git a/static/js/referee_panel.js b/static/js/referee_panel.js
index 88a7e4b7..9bea3c1d 100644
--- a/static/js/referee_panel.js
+++ b/static/js/referee_panel.js
@@ -47,11 +47,6 @@ var cycleCard = function(cardButton) {
   $(cardButton).attr("data-card", newCard);
 };
 
-// Sends a websocket message to signal to the volunteers that they may enter the field.
-var signalVolunteers = function() {
-  websocket.send("signalVolunteers");
-};
-
 // Sends a websocket message to signal to the teams that they may enter the field.
 var signalReset = function() {
   websocket.send("signalReset");
diff --git a/templates/match_play.html b/templates/match_play.html
index f42fe9e7..d2b8f5a7 100644
--- a/templates/match_play.html
+++ b/templates/match_play.html
@@ -53,10 +53,6 @@
           onclick="abortMatch();" disabled>
         Abort Match
       </button>
-      <button type="button" id="signalVolunteers" class="btn btn-warning btn-lg btn-match-play"
-          onclick="signalVolunteers();" disabled>
-        Signal Volunteers
-      </button>
       <button type="button" id="signalReset" class="btn btn-success btn-lg btn-match-play"
           onclick="signalReset();" disabled>
         Signal Reset
diff --git a/templates/referee_panel.html b/templates/referee_panel.html
index 0a8c2870..e5016db8 100644
--- a/templates/referee_panel.html
+++ b/templates/referee_panel.html
@@ -34,7 +34,6 @@ <h3>Fouls</h3>
 </div>
 <p>Note: Team and rule assignment are optional.</p>
 <div id="controlButtons">
-  <div class="control-button" id="volunteerButton" onclick="signalVolunteers();">Signal Volunteers</div>
   <div class="control-button" id="resetButton" onclick="signalReset();">Signal Reset</div>
   <div class="control-button" id="commitButton" onclick="commitMatch();">Commit Match</div>
 </div>
diff --git a/web/match_play.go b/web/match_play.go
index 85604591..44828908 100644
--- a/web/match_play.go
+++ b/web/match_play.go
@@ -277,13 +277,6 @@ func (web *Web) matchPlayWebsocketHandler(w http.ResponseWriter, r *http.Request
 				ws.WriteError(err.Error())
 				continue
 			}
-		case "signalVolunteers":
-			if web.arena.MatchState != field.PostMatch && web.arena.MatchState != field.PreMatch {
-				// Don't allow clearing the field until the match is over.
-				continue
-			}
-			web.arena.FieldVolunteers = true
-			continue // Skip sending an arena status update.
 		case "signalReset":
 			if web.arena.MatchState != field.PostMatch && web.arena.MatchState != field.PreMatch {
 				// Don't allow clearing the field until the match is over.
diff --git a/web/referee_panel.go b/web/referee_panel.go
index 05abf146..500f3f86 100644
--- a/web/referee_panel.go
+++ b/web/referee_panel.go
@@ -181,12 +181,6 @@ func (web *Web) refereePanelWebsocketHandler(w http.ResponseWriter, r *http.Requ
 			}
 			cards[strconv.Itoa(args.TeamId)] = args.Card
 			web.arena.RealtimeScoreNotifier.Notify()
-		case "signalVolunteers":
-			if web.arena.MatchState != field.PostMatch {
-				// Don't allow clearing the field until the match is over.
-				continue
-			}
-			web.arena.FieldVolunteers = true
 		case "signalReset":
 			if web.arena.MatchState != field.PostMatch {
 				// Don't allow clearing the field until the match is over.