Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming dialog should appear earlier #16

Open
Rafii2198 opened this issue Feb 22, 2023 · 6 comments
Open

Renaming dialog should appear earlier #16

Rafii2198 opened this issue Feb 22, 2023 · 6 comments

Comments

@Rafii2198
Copy link

It would be really nice if the dialog that asks if the original file should be renamed appeared earlier rather than it finished. The main reason for it is that it would let you just leave it update and go do something else and then when you are back you could instantly launch Minecraft, now you have to go back to the installer, decide if you want to rename, and then it is done.
It is rather small but still would be nice.

@nullTheCoder
Copy link
Collaborator

Installer is getting deprecated as soon as I am done with with vow-core and that is turned into vow2, so I don't think there is any point in adding this now.

@Rafii2198
Copy link
Author

Oh, I didn't know that, kinda a bummer, but alright then...

@nullTheCoder
Copy link
Collaborator

It's fine, it is really unknown when I will finish vow-core, and in a way what you said would be good for the installer, however because the installer seems to have been starting to fail more and more recently it feels like a good idea to get rid of it.

@Rafii2198
Copy link
Author

Oh, I personally never had any issues with it

@ShadyMedic
Copy link
Member

Honestly, I think that we can remove that dialoge box completely and just rename the file without asking.

@nullTheCoder
Copy link
Collaborator

Maybe we could do that in a parallel universe where there were not any plans on vow-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants