-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlist are incomplete when sync specific library #298
Comments
Very interesting suggestions. |
perhaps, for now, disable playlist logic if the user doesn't do full library sync and print a warning about that? |
yes, i'm ok with this idea |
Checked this code recently, sharing some info. Python Plex has check that all items in the list are either |
Disabling when |
I don't see how the rest of the problem is solvable. if you sync movies library only, you could workaround by not clearing the existing list of shows, but then the ordering will be wrong. |
Description
When user sync lists but doesn't sync all libraries, the plex playlist can be incomplete because of partial script browsing of plex library. A log info could warn that list sync may be incomplete.
I may also be more than a feature request because it also updates lists and remove items from them. Looks like a real issue.
Use case
Step-by-step example:
--sync tv
argumentExpected: Plex having a new playlist containing movies from trakt liked list
What happens really: Plex playlist doesn't contain movies because script didn't run through movies library
If user sync only movies, playlists will be updated and tv episodes removed from them.
If user sync only tv, playlists will be updated and movies removed from them.
Line specific for movies or tv :
PlexTraktSync/plex_trakt_sync/commands/sync.py
Line 130 in c7836e3
Line always run :
PlexTraktSync/plex_trakt_sync/commands/sync.py
Line 146 in c7836e3
The list syncing logic is to go through every plex item during the library sync. And when an item matches with a trakt list, it is added to the plex list. If the script doesn't browse all libraries, we cannot be sure the plex playlist will be complete.
#228 (comment)
Workarounds
The text was updated successfully, but these errors were encountered: