Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists not created from Liked Lists #1177

Closed
2 tasks done
NGDM opened this issue Nov 8, 2022 · 14 comments
Closed
2 tasks done

Playlists not created from Liked Lists #1177

NGDM opened this issue Nov 8, 2022 · 14 comments
Labels
docs needed Changes in this issue/pull request need to be documented

Comments

@NGDM
Copy link
Contributor

NGDM commented Nov 8, 2022

Confirmation

  • I have read the README.md on the project homepage
  • I have checked if identical issue already exists

The problem

Ever since the #941 bug the sync of Trakt liked lists to Plex playlists has stopped working.

In the logs they still seem to be downloaded, but I can't find them in my Plex Playlists.
Nothing in the logs seem to show an issue/warning/error, not even in debug logs.

I tried unliking, syncing, liking and syncing again to trigger a redownload, but still no cigar.

Also tried with a new setup from scratch, still no sync.

Error trace / logs

INFO     Downloaded List 1001 Greatest Movies of All Time                       
INFO     Downloaded List Lord of the Rings                                      
INFO     Downloaded List All of these Films are Worth Seeing (1400 Titles)      
INFO     Downloaded List Movies from the last decade [couchmoney.tv]            
INFO     Downloaded List Recommended Movies                                     
INFO     Downloaded List The Best Movie You Never Saw                           
INFO     Added to list 1001 Greatest Movies of All Time:                        
         <Movie:9643:Princess-Mononoke>                                         
Processing Anime Movies  77% ━━━━━━━━╺━━ 23/30  [ 0:00:00 < 0:00:01 , 214 it/s ]
INFO     Anime Movies processed in 0.6 seconds                                  
INFO     Added to list All of these Films are Worth Seeing (1400 Titles):       
         <Movie:22780:Accepted>                                                 
INFO     Added to list 1001 Greatest Movies of All Time:                        
         <Movie:19096:The-Aviator>                                              
INFO     Added to list All of these Films are Worth Seeing (1400 Titles):       
         <Movie:19096:The-Aviator>       
…

Expected behavior

I would expect my liked lists being present in Plex as playlists.

Steps to reproduce the behavior

  1. docker-compose run --rm plextraktsync2
  2. follow setup steps (Plex login, Trakt login)
  3. let script finish
  4. check playlists in Plex

Inspect of problematic items

No response

Workarounds

No response

Install method

docker-compose

Config file contents

cache:
  path: $PTS_CACHE_DIR/trakt_cache

excluded-libraries:
  - Family
  - HDD Movies
  - HDD TV Shows

config:
  dotenv_override: true

logging:
  append: false
  debug: false
  filename: plextraktsync.log

sync:
  plex_to_trakt:
    collection: true
    ratings: true
    watched_status: true
    watchlist: false
  trakt_to_plex:
    liked_lists: true
    ratings: true
    watched_status: true
    watchlist: true

watch:
  add_collection: true
  remove_collection: true
  scrobble_threshold: 80
  username_filter: true

xbmc-providers:
  movies: imdb
  shows: tvdb

# vim:ts=2:sw=2:et

Version

0.23.8-19-gcfad5c9_main

Python Version

3.10.8

Operating System and Version

Docker (Ubuntu)

@glensc
Copy link
Collaborator

glensc commented Nov 8, 2022

Workarounds

No response

Downgrade? and please specify what version downgrade helped!

@glensc
Copy link
Collaborator

glensc commented Nov 8, 2022

Version

0.23.8-19-gcfad5c9_main

(While it probably is not broken in this case) We don't do support for development versions. (unless a developer particularly asked to test some development version).

@NGDM
Copy link
Contributor Author

NGDM commented Nov 8, 2022

Workarounds
No response

Downgrade? and please specify what version downgrade helped!

Tried going back to 0.23.0 since everything before that fails on #941
Still the same thing.

Version
0.23.8-19-gcfad5c9_main

(While it probably is not broken in this case) We don't do support for development versions. (unless a developer particularly asked to test some development version).

I guess this is because I've been using image: 'ghcr.io/taxel/plextraktsync:main' for my docker container.
I switched to :latest instead, but as you said it didn't fix this issue.

I've now also tried on a different Plex server and get the same results.
Am I really the only one with this issue?

Not sure what else I could try?

@glensc
Copy link
Collaborator

glensc commented Nov 8, 2022

Not sure what else I could try?

since you said it worked before, find the version where it worked.

@NGDM
Copy link
Contributor Author

NGDM commented Nov 8, 2022

That would be somewhere before the bug I already mentioned (#941) which broke this script for a while until the PyTrakt project was forked…
I believe it was caused because of an update to the Trakt Lists API?

So I can't really go back further without mocking the Trakt API or smth (wouldn't even know where to begin though).

Could you check if this functionality works for you @glensc?

@NGDM
Copy link
Contributor Author

NGDM commented Nov 8, 2022

I'm wondering if the python-plexapi is the issue here.
Is it possible to output the plex-api logs in DEBUG/TRACE level within the PTS container?

Docu: https://python-plexapi.readthedocs.io/en/latest/configuration.html

@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

Could you check if this functionality works for you @glensc?

I don't use the feature, so first need to understand how it's supposed to work. If you describe step by step, it could help. maybe even submit a change to README?

I believe it was caused because of an update to the Trakt Lists API?

for #941 You will need this change:

you can mock it with making a copy from the image and bind mounting it to container, or just modify the file inside the container before running the app.

@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

Is it possible to output the plex-api logs in DEBUG/TRACE level within the PTS container?

yes. it's documented in readme how to enable debug logging.

@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

you could also bind mount ~/.config/plexapi/config.ini to container, I believe /root/.config/plexapi/config.ini is the path, but enabling debug in pts worked so far:

  • # Set debug for other components as well
    if log_level == logging.DEBUG:
    from plexapi import log as logger
    from plexapi import loghandler
    logger.removeHandler(loghandler)
    logger.setLevel(logging.DEBUG)

@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

but, have you tried this PR:

does it change anything for you?

@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

From #1177 (comment)

I don't use the feature, so first need to understand how it's supposed to work. If you describe step by step, it could help.

don't forget to describe what config keys must be enabled.

@NGDM
Copy link
Contributor Author

NGDM commented Nov 9, 2022

but, have you tried this PR:

* [Add trakt official lists support #1162](https://github.com/Taxel/PlexTraktSync/pull/1162)

does it change anything for you?

Tried this but didn't fix it.

From #1177 (comment)

I don't use the feature, so first need to understand how it's supposed to work. If you describe step by step, it could help.

don't forget to describe what config keys must be enabled.

  1. Like a public (non-official) list on Trakt. For example (make sure you have some movies from the list on your Plex server as well)
  2. Set the liked_lists config under trakt_to_plex to true
  3. Run a regular PTS sync, wait for finish.
  4. Check on your Plex server's "Playlists" library if the liked playlist has been added to it.
    Inside should be the movies from the Trakt list which are present on your server.

@NGDM
Copy link
Contributor Author

NGDM commented Nov 9, 2022

Found the issue!

I believe the issue is caused by this commit:

Here a new config was implemented for watchlist_as_playlist and some logic was changed.
More precise: This method is only ran when watchlists are synced (one of watchlist configs set to true) and trakt_to_plex["watchlist_as_playlist"] is true, which is wrong, since it should also be called when only liked_lists is true.

Another strange occurrence is the liked list sync only happens when the trakt_to_plex["watchlist"] config is true.
This line seems to indicate it should run as well if plex_to_trakt["watchlist"] is true I believe?

Could you try to rework this to also allow when only liked lists are synced?

@glensc glensc added the docs needed Changes in this issue/pull request need to be documented label Nov 9, 2022
@glensc
Copy link
Collaborator

glensc commented Nov 9, 2022

marking as "docs needed" label. you're welcome to send documentation update. the other problem you can send feature request.

you can probably copy most of the docs from here:

@glensc glensc closed this as completed Nov 9, 2022
@glensc glensc closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needed Changes in this issue/pull request need to be documented
Projects
None yet
Development

No branches or pull requests

2 participants