Don't overwrite the users variables

[Tarrasch]

Currently, if a user of zsh-functional has the shell variable x defined, it'll be rewritten by some temporary value by the internals of zsh-functional.

[Tarrasch]

Example:

~  
❯ x=4

~  
❯ apply () { $2 $1 }

~  
❯ time eachf 'apply hi' $colors
hi
hi
hi
hi
hi
hi
hi
hi

~  
❯ echo $
$

~  
❯ echo $x
white

[swistak35]

Indeed. The same would be with go function, it took me some time to figure out what's wrong with my zshrc that map doesn't work. Maybe renaming functions for something like _funcs_x, _funcs_go?

[Tarrasch]

Well, it will not work for the variable x, after all the purpose is that you can use it it in the lambda expressions. However, it makes sense for the helper function go. Do you mind creating a PR for this? I would love to see another contributor (otherwise I'm fine with doing it.

I think the easiest solution for go is just to rename it to _zsh-functional_go. I think it's worth being explicit here. :)

By the way, I'm really grateful for finding this old issue, I should start fixing things for this project. :)

[swistak35]

Sure, I will do that. : )

[Tarrasch]

That's awesome! Just say if you want any help, and I have a complete test-suite as well, so don't be afraid that things might break. :)

[Tarrasch]

Argh, I just got bitten by this myself, I guess I should update my own software! :)

[NightMachinery]

@Tarrasch I don't see why we need x in lambdas? What's wrong with $1? Anyways, can't you use local x in the internals?

[Tarrasch]

What's wrong with $1?

I find it unintuitive. Also we want to highlight that we're dealing with "special" syntax.

Anyways, can't you use local x in the internals?

Maybe. I haven't touched this in a while. Do you mind trying it out? If so please remember test cases!

[NightMachinery]

I find “$1” very intuitive 😆 Don’t count on me for fixing the X bug anytime soon, I won’t get to it if it doesn’t cause me problems.

…

On Sat, Oct 20, 2018 at 9:46 PM Arash Rouhani ***@***.***> wrote: What's wrong with $1? I find it unintuitive. Also we want to highlight that we're dealing with "special" syntax. Anyways, can't you use local x in the internals? Maybe. I haven't touched this in a while. Do you mind trying it out? If so please remember test cases! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aii--lla9iXlkd-QfFjkXRfmjjc53YhKks5um2higaJpZM4AfNjI> .