Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS-PHP no longer supports PHP 7.4 #93

Closed
eliot-akira opened this issue Mar 14, 2024 · 0 comments
Closed

SCSS-PHP no longer supports PHP 7.4 #93

eliot-akira opened this issue Mar 14, 2024 · 0 comments

Comments

@eliot-akira
Copy link
Contributor

eliot-akira commented Mar 14, 2024

From this commit comment by @nicolas-jaussaud:

the minimal php version for SCSS-PHP is now 8.1

Are we also switching to php 8.1 and above as the minimal version for template-system and the associated projects, or should we still try to correct anything we encounter that is not php 7.4 compatible?


According to the WordPress usage statistics, 43% of users are still on PHP 7.4. So we should maintain compatibility until more people switch over.

From the recent Git history in SCSS-PHP, they're modernizing a lot of the code. We can fork it but I'm afraid of the effort it would take to keep an eye on every upstream change and modify it for PHP 7.4 (which might not be technically possible in some cases).

For now, I suppose we need to revert the Sass compiler to the latest backward-compatible version of SCSS-PHP (right before that commit you linked to).

--

There are some basic tests for the Sass compiler, which get run on both PHP 8.2 and 7.4. They're all passing even after the upgrade to SCSS-PHP 1.12.1, and I don't see any PHP syntax errors or warnings.

So maybe we can "freeze" it at this point, until we figure out how to move away from SCSS-PHP altogether:

eliot-akira referenced this issue Mar 14, 2024
- Resolves #85
- Add tests for edge cases
- Known issue with handling of slashes in CSS values
  - scssphp/scssphp#146
  - See #82 - Workaround is to use `unquote('..')`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant