Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prosopal for my first contribution #3508

Open
SlickMoose opened this issue Jan 25, 2025 · 2 comments
Open

Prosopal for my first contribution #3508

SlickMoose opened this issue Jan 25, 2025 · 2 comments

Comments

@SlickMoose
Copy link

First of all, I’d like to thank you for creating this project. I recently started using it and it’s an amazing!

Before discovering Tandoor, I had been using bediet.pl for several years. While it fulfilled most of my needs, it wasn’t open source, so I couldn’t contribute or request new features to make it more aligned with my workflow.

Below, I’ve outlined some ideas and areas I’d like to work on to improve both the UI/UX and functionality of the app:

  1. General Layout Enhancements
    Increase contrast across the interface to improve readability.
    Make the design more intuitive and responsive for both desktop browsers and mobile devices.

  2. Add a "Day" option to the "Period" dropdown in meal plan to show meals for a specific day.
    Display each meal as a separate card component, including:

    • Recipe details.
    • Nutritional breakdown per recipe.
    • Ingredients and step-by-step instructions.
      Add a summary view for the day that aggregates total calories and nutritional values.
  3. Add the ability to toggle between grid view (adjustable column count) and list view for recipes and products.

  4. Shopping List Improvements
    Rework the shopping list functionality to allow multiple lists instead of one unified view.
    Each list can be tied to a specific meal plan period (e.g., week, day).
    Inside each list:

    • Allow categorization of items by supermarkets or product categories.
    • Add the ability to manually include additional items (not from the meal plan).

    Present lists as checklists that don’t disappear after marking items as completed, making them easier to manage.

I have a lot more ideas but wanted to start with these as my first contribution. 😊 I’d love to hear your feedback and discuss which of these features align with the project’s roadmap and philosophy.

Let me know if I should further refine any of these ideas or provide more technical details before diving into development!

I have knowledge of django (1 year) and react (3 years) (ready to start learning vue)

@SlickMoose SlickMoose marked this as a duplicate of #3507 Jan 25, 2025
@vabene1111
Copy link
Collaborator

hi, thanks for your post with the ideas. It is very good to discuss them before you start working. The whole project is currently being rewritten in the frontend (see #2976) this means that some of the points you made have already been addressed to some degree.

  1. feel free to take a look at the vue 3 branch, i think its already a lot better but if you have ideas feel free to implement them and we can discuss screenshots
  2. I like the idea. I have big plans for the integration of properties and the meal plan that are written down in some issue somewhere but having a day (and week) view with more details would be cool. There is a bigger topic with the way properties are handled tough so I am not sure if the backend is ready for this.
  3. this has been changed a lot, take a look at vue 3 branch if you have any improvement ideas
  4. I have several ideas and wishes here as well, you can already categorize and add manually with the current version but there is no multi list support.

Generally speaking I do not want to make any database changes as long as the rework is in progress, so if you want to work on things the most helpful would currently would be design improvements and bugfixes on the vue 3 branch. There are also some missing features and TODOs that can be found in the associated project https://github.com/orgs/TandoorRecipes/projects/1.
Also one important mistake I have made with this project in the past is to accept features from contributors and then drown in the flood of maintenance work that followed those features in the years past. I only accept well written and thought trough code that I think I can easily maintain over the years, as that has almost broken this project in the past.

@SlickMoose
Copy link
Author

SlickMoose commented Jan 29, 2025

Thanks for the warm welcome and the detailed feedback! I’ve cut my teeth building my first frontends using React, so I’ll do my best to avoid the same mistakes and keep things maintainable.

Is there a guide for properly setting up Vite for the dev server? I’m using a dev container in VSCode, but I can’t get the homepage to load. I’m getting this error:

main.ts:74 [Vue Router warn]: No match found for location with path "/static/vue3/"

EDIT: made it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants