Maximum update depth exceeded

[yWilliamLima]

Describe the bug

I am getting the error "Maximum update depth exceeded"

Your minimal, reproducible example

https://stackblitz.com/~/github.com/yWilliamLima/test-error

Steps to reproduce

It usually occurs after a while of running whenever changing pages/routes

Expected behavior

Do not return this error

How often does this bug happen?

Sometimes

Screenshots or Videos

Platform

OS: Windows 11
Browser: Chrome
Node: 22.12.0

Tanstack Query adapter

None

TanStack Query version

5.66.5

TypeScript version

5.7.3

Additional context

The error in the console does not occur locally, only in stackblitz
Maybe because of this error in the stackblitz console it doesn't happen, because it gives a refresh
Because it is a minimal example, it takes a while to occur, but in my project it occurs frequently

[tariqkb]

I started getting this error after upgrading as well. I narrowed it down to version v5.66.4 introducing this behavior.

[yWilliamLima]

I started getting this error after upgrading as well. I narrowed it down to version v5.66.4 introducing this behavior.

Your test is very good, the problem was actually introduced in v5.66.4, I downgraded to v5.66.3 and the problem does not occur

[TkDodo]

@juliusmarminge 5.66.4 was our hydration changes 😕

[joseph0926]

I think the following part of the logic added by #8383 in the PR might be causing some problems.

https://github.com/TanStack/query/pull/8383/files#diff-771e81c633f399ddff578509c1355021bff3ce55afb12d281cb9bc110842665fR83-R86

This is because the code in the above link thinks that the new logic is new if the “promise.status” is different.

But https://github.com/TanStack/query/pull/8383/files#diff-da66ebb93eacffd07c6ea6e697db57d6091050af95da336ea10e1aaedb07ef7cR86 is chasing a “promise”, so I think a new “promise” will be created each time.
(or is the “promise.status” actually different each time?)

Wouldn't that cause “Maximum update depth exceeded” to be thrown because the new code thinks it's new every time?

[juliusmarminge]

can anyone provide a minimal repro? I can look into this tonight but would help to have something simple to debug

[yWilliamLima]

I did some validations in my personal project where the error occurs frequently, where if I export the Page as async and use await in prefetchQuery the problem does not occur:

export default async function Page() {
  const queryClient = getQueryClient()

  await queryClient.prefetchQuery({ ...getApiV1ActivitiesOptions() })

[juliusmarminge]

yea but then you're no longer sending promises down so you're hitting completely different code paths with that - not really comparable

[juliusmarminge]

I just want a state where it's failing on that PR I linked 😅