Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Lists' lag #13

Open
markzyu opened this issue Mar 29, 2016 · 2 comments
Open

UI Lists' lag #13

markzyu opened this issue Mar 29, 2016 · 2 comments

Comments

@markzyu
Copy link

markzyu commented Mar 29, 2016

The cause seems to be loading Realm in UI Thread. However, even if loading Realm in UI is avoided, the asynchronous procedure of refreshing any list item just due to scrolling is not acceptable.

We could fix this by loading full data in before enabling ListAdapters or rendering lists.

@markzyu
Copy link
Author

markzyu commented Mar 29, 2016

An example of such an issue appears in MainBillFragment. It was solved in f5f1b28.

But we still have many other fragments to fix.

@markzyu
Copy link
Author

markzyu commented Mar 29, 2016

Steps:

  1. Change a function signature in some IView: avoid passing in RawXXX and pass ShownXXX instead, which should contain all the data needed to inflate the view (it's fine for images to be given by URL, though)
  2. Fix related function implementations. And move the code fetching extra data from Views to Presenters.

@markzyu markzyu mentioned this issue Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant