Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] UI #30

Open
ngluva opened this issue Jul 7, 2021 · 13 comments
Open

[Feature Request] UI #30

ngluva opened this issue Jul 7, 2021 · 13 comments

Comments

@ngluva
Copy link

ngluva commented Jul 7, 2021

Interesting project, some things I have noticed.
1). The Diagram name should be saved with the diagram.
2). It would be handy to be able to close a diagram without having to shut the app down and starting again from TablePlus with an empty diagram.
3). "Delete diagram" should be renamed "Remove diagram", because the diagram is not deleted.
4). Opening a diagram shouldn't replace the contents of the currently selected diagram without warning the user.
5). If there are no Diagrams loaded and you open an existing one then the diagram is not displayed until you add a diagram.
6). The column name text should be selected on focus when adding a column

Cheers

@huyphams
Copy link
Contributor

huyphams commented Jul 7, 2021

Why do we need to shutdown the app in order to close the diagram @ngluva you can click the close button and then the diagram windows will be closed.

@thien-do
Copy link

thien-do commented Jul 7, 2021

Those are great suggestions @ngluva !

3). "Delete diagram" should be renamed "Remove diagram", because the diagram is not deleted.

Can you elaborate a little bit? The "Delete" option does delete the diagram completely:

image

4). Opening a diagram shouldn't replace the contents of the currently selected diagram without warning the user.
5). If there are no Diagrams loaded and you open an existing one then the diagram is not displayed until you add a diagram.
6). The column name text should be selected on focus when adding a column

Yeah these are known issues 😅

@ngluva
Copy link
Author

ngluva commented Jul 7, 2021

Thanks for the rapid response!

Why do we need to shutdown the app in order to close the diagram @ngluva you can click the close button and then the diagram windows will be closed.

The issue arises when we are working on many diagrams and we want to close one diagram. Sure I can use the close box but that closes the app and then we have to go back to TablePlus and open that app. From a user point of view it is just not what people would expect.

@huyphams
Copy link
Contributor

huyphams commented Jul 7, 2021

You don't have to do that @ngluva , you can click this button and add an empty diagram.
close

@ngluva
Copy link
Author

ngluva commented Jul 7, 2021

Those are great suggestions @ngluva !

3). "Delete diagram" should be renamed "Remove diagram", because the diagram is not deleted.

Can you elaborate a little bit? The "Delete" option does delete the diagram completely:

image

4). Opening a diagram shouldn't replace the contents of the currently selected diagram without warning the user.
5). If there are no Diagrams loaded and you open an existing one then the diagram is not displayed until you add a diagram.
6). The column name text should be selected on focus when adding a column

Yeah these are known issues 😅

I guess the concern comes from the word and the action defined by "delete" and the dire warning in the dialog box. The diagram file (if saved) is not deleted but the diagram is removed from the window.

@huyphams
Copy link
Contributor

huyphams commented Jul 7, 2021

So you use the diagram on the website https://diagramplus.com/ and not from the TablePlus plugin?
Screen Shot 2021-07-07 at 12 14 59 PM

@ngluva
Copy link
Author

ngluva commented Jul 7, 2021

You don't have to do that @ngluva , you can click this button and add an empty diagram.
close

OK, maybe this is a windows thing, but the only way to close a diagram is to close the app and return via TablePlus.

@ngluva
Copy link
Author

ngluva commented Jul 7, 2021

So you use the diagram on the website https://diagramplus.com/ and not from the TablePlus plugin?
Screen Shot 2021-07-07 at 12 14 59 PM

Yes, I've use the website but it's kind of the same thing.

@huyphams
Copy link
Contributor

huyphams commented Jul 7, 2021

I'm confused, I don't understand what you want to achieve? So you want to open an empty diagram or something else?

@thien-do
Copy link

thien-do commented Jul 7, 2021

I guess the concern comes from the word and the action defined by "delete" and the dire warning in the dialog box. The diagram file (if saved) is not deleted but the diagram is removed from the window.

Ah I understand this @ngluva ! I'll think about this. Your suggestion makes sense.

@thien-do
Copy link

thien-do commented Jul 7, 2021

The issue arises when we are working on many diagrams and we want to close one diagram. Sure I can use the close box but that closes the app and then we have to go back to TablePlus and open that app. From a user point of view it is just not what people would expect.

If I understand correctly, you would expect each diagram would have its own window, so you can close one and leave the others untouched? Meanwhile, the current behaviour is that all diagrams are inside one single window?

@ngluva
Copy link
Author

ngluva commented Jul 7, 2021

The issue arises when we are working on many diagrams and we want to close one diagram. Sure I can use the close box but that closes the app and then we have to go back to TablePlus and open that app. From a user point of view it is just not what people would expect.

If I understand correctly, you would expect each diagram would have its own window, so you can close one and leave the others untouched? Meanwhile, the current behaviour is that all diagrams are inside one single window?

Yes. Each diagram should be in a tab.

I mentioned these things because the app has great promise. The animation makes it very easy to explain to non-programmers the information flow and the table editing works OK .

@thien-do
Copy link

thien-do commented Jul 7, 2021

yeah believe me I couldn't be happier to hear that 👍

Yes. Each diagram should be in a tab.

Yeah let me think how can we achieve this :D it's not a straightforward change from the current behavior (only diagram at a time, with the sidebar for listing) but it seems useful so it deserves some thought.

Just leave this issue open, I'll let you know if there's any update :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants