Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the generated diagram include the comment and index? #14

Open
xialvjun opened this issue Oct 30, 2020 · 2 comments
Open

Can the generated diagram include the comment and index? #14

xialvjun opened this issue Oct 30, 2020 · 2 comments

Comments

@xialvjun
Copy link

And export to database also include the comment and index.

@thien-do
Copy link

The comment should be simple. There's actually a community PR for "comment" column in MySQL (merged) at #2

In fact it's all possible and the relevant code is in https://github.com/TablePlus/diagram-plugin/blob/8cfebeff47c74cddfe961096247fa67c0b893b97/diagram.tableplusplugin/library/helper.js (it's specific for each DB though)

I mean, eventually we will support many more columns, but if you don't want to wait you can do it yourself with a PR to this PR :D

@thien-do
Copy link

The "index" part may be a little bit more complicated. At the moment I'm not sure if it can be done solely here (this open-sourced "diagram-plugin") or it will require some changes in the diagram app. I'll take more look and update here :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants