From 71c209e86562d957f04b29a589d928565d8d3f69 Mon Sep 17 00:00:00 2001 From: zzgu Date: Mon, 6 Jan 2025 11:21:28 -0800 Subject: [PATCH] resolve comments --- clients/vscode/src/lsp/CodeLensMiddleware.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/vscode/src/lsp/CodeLensMiddleware.ts b/clients/vscode/src/lsp/CodeLensMiddleware.ts index 1e563f795899..dfddcca13c73 100644 --- a/clients/vscode/src/lsp/CodeLensMiddleware.ts +++ b/clients/vscode/src/lsp/CodeLensMiddleware.ts @@ -76,11 +76,11 @@ export class CodeLensMiddleware implements VscodeLspCodeLensMiddleware { return codeLenses; } + this.removeDecorations(editor); if (!codeLenses) { return []; } - this.removeDecorations(editor); const result = codeLenses .map((codeLens) => this.handleCodeLens(codeLens, editor)) .filter((codeLens): codeLens is CodeLens => codeLens !== null); @@ -114,8 +114,8 @@ export class CodeLensMiddleware implements VscodeLspCodeLensMiddleware { private addShortcut(codeLens: CodeLens) { if (codeLens.command?.arguments?.[0].action === "accept") { - // TODO: read ~/.config/Code/User/keybindings.json from LSP client, then send to LSP server to avoid hardcode. - const acceptShortcut = isBrowser ? "" : ` (${process.platform === "darwin" ? "cmd+enter" : "ctrl+enter"})`; + // FIXME: Read ~/.config/Code/User/keybindings.json from LSP client, then send to LSP server to avoid hardcode. + const acceptShortcut = isBrowser ? '' : ` (${process.platform === 'darwin' ? '⌘+enter' : 'Ctrl+enter'})`; codeLens.command.title += acceptShortcut; } else if (codeLens.command?.arguments?.[0].action === "discard") {