Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JSONP in autosuggest prevents CSP #2556

Closed
Tracked by #3356
masi opened this issue Apr 9, 2020 · 7 comments
Closed
Tracked by #3356

[BUG] JSONP in autosuggest prevents CSP #2556

masi opened this issue Apr 9, 2020 · 7 comments

Comments

@masi
Copy link

masi commented Apr 9, 2020

Describe the bug
I have to enable policy unsafe-eval when I want the default autosuggest client code.
The problem is that JSONP requires the use of eval() on the client side JSONP has been superceded by CORS for a very long time.

@Zillion01
Copy link

This is still a security issue in 11.5, hopefully this can be picked up

@emileblume
Copy link

Yes, please pick this up

@dkd-kaehm
Copy link
Collaborator

This is still a security issue in 11.5, hopefully this can be picked up

@masi, @Zillion01, @emileblume
The pull requests are welcome, please provide a change suggestions.

@Zillion01
Copy link

Thanks for your reaction. This is a project in which I am not specialized, however I do work for companies who pay DKD for SOLR updates. How do other auto suggest options work without jquery.autocomplete. The thing is, autosuggest is an important feature, but forces insecure configuration of CSP headers which makes it in my opinion one of the most urgent needed code changes.

@emileblume
Copy link

emileblume commented Oct 7, 2022

Same here. We have municipalities as client that also pay for DKD. I think it's irresposible that this hasn't been fixed earlier.

@proudnerds-typo3
Copy link

Why hasn't this been picked up? With the CSP settings in TYPO3 12 it's not possible to use the auto-suggest, our clients are complaning about this. I find it pretty strange and even annoying we still have to wait for someone who acknowledges that this is a real problem.

dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Dec 17, 2024
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: TYPO3-Solr#2556
Ports: TYPO3-Solr#4201
@dkd-kaehm
Copy link
Collaborator

@proudnerds-typo3
Please test and review changes from #4267.

All interested parties on older EXT:solr versions:

Please use composer patches from https://patch-diff.githubusercontent.com/raw/TYPO3-Solr/ext-solr/pull/4267.patch

dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Dec 17, 2024
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: TYPO3-Solr#2556
Ports: TYPO3-Solr#4201
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jan 13, 2025
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: TYPO3-Solr#2556
Ports: TYPO3-Solr#4201
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jan 27, 2025
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: TYPO3-Solr#2556
Ports: TYPO3-Solr#4201
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jan 29, 2025
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: TYPO3-Solr#2556
Ports: TYPO3-Solr#4201
dkd-kaehm added a commit that referenced this issue Jan 29, 2025
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.

See https://en.wikipedia.org/wiki/JSONP#Security_concerns

Fixes: #2556
Ports: #4201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants