From c5f7d08e37d8f592c3478ecc2e624b7c2d811674 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20DANIEL?= <dogawaf@no-log.org>
Date: Tue, 17 Sep 2024 08:03:26 +0200
Subject: [PATCH] [TASK] Remove unnecessary call_user_func wrapping in TCA
 override example (#4765)

References TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/issues/4756
Releases: main,12.4
---
 .../AddingYourOwnContentElements.rst          | 10 ++---
 .../_tt_content.php                           | 37 +++++++++----------
 2 files changed, 22 insertions(+), 25 deletions(-)

diff --git a/Documentation/ApiOverview/ContentElements/AddingYourOwnContentElements.rst b/Documentation/ApiOverview/ContentElements/AddingYourOwnContentElements.rst
index 71b0c5b83..70b1ffb8a 100644
--- a/Documentation/ApiOverview/ContentElements/AddingYourOwnContentElements.rst
+++ b/Documentation/ApiOverview/ContentElements/AddingYourOwnContentElements.rst
@@ -80,7 +80,7 @@ The following call needs to be added to the file
 ..  literalinclude:: _AddingYourOwnContentElements/_tt_content.php
     :caption: EXT:my_extension/Configuration/TCA/Overrides/tt_content.php
     :linenos:
-    :emphasize-lines: 12
+    :emphasize-lines: 10
 
 Now the new content element is available in the CType selector and the
 "New Content Element" wizard.
@@ -114,7 +114,7 @@ The new content element wizard
 ..  literalinclude:: _AddingYourOwnContentElements/_tt_content.php
     :caption: EXT:my_extension/Configuration/TCA/Overrides/tt_content.php
     :linenos:
-    :emphasize-lines: 17,18,19
+    :emphasize-lines: 15,16,17
 
 The values in the array highlighted in the code example above are used for the
 display in the :guilabel:`New Content Element` wizard.
@@ -146,13 +146,13 @@ the file :file:`Configuration/TCA/Overrides/tt_content.php`:
 ..  literalinclude:: _AddingYourOwnContentElements/_tt_content.php
     :caption: EXT:my_extension/Configuration/TCA/Overrides/tt_content.php
     :linenos:
-    :emphasize-lines: 28,29
+    :emphasize-lines: 26,27
 
-In line 28 a custom :ref:`palette <t3tca:palettes>` with the header and related
+In line 27 a custom :ref:`palette <t3tca:palettes>` with the header and related
 fields is displayed. This palette and its fields are defined in
 :t3src:`typo3/sysext/frontend/Configuration/TCA/tt_content.php`.
 
-In line 29 a predefined field, `bodytext` is added to be displayed in the
+In line 28 a predefined field, `bodytext` is added to be displayed in the
 form of the new content element type.
 
 .. index:: Content element; Frontend rendering
diff --git a/Documentation/ApiOverview/ContentElements/_AddingYourOwnContentElements/_tt_content.php b/Documentation/ApiOverview/ContentElements/_AddingYourOwnContentElements/_tt_content.php
index f0eb3ba58..300dd570e 100644
--- a/Documentation/ApiOverview/ContentElements/_AddingYourOwnContentElements/_tt_content.php
+++ b/Documentation/ApiOverview/ContentElements/_AddingYourOwnContentElements/_tt_content.php
@@ -5,28 +5,25 @@
 
 defined('TYPO3') or die();
 
-call_user_func(function () {
+$key = 'myextension_basiccontent';
 
-    $key = 'myextension_basiccontent';
+// Adds the content element to the "Type" dropdown
+ExtensionManagementUtility::addTcaSelectItem(
+    'tt_content',
+    'CType',
+    [
+        'label' => 'Example - basic content',
+        'value' => $key,
+        'group' => 'default',
+    ],
+    'textmedia',
+    'after',
+);
 
-    // Adds the content element to the "Type" dropdown
-    ExtensionManagementUtility::addTcaSelectItem(
-        'tt_content',
-        'CType',
-        [
-            'label' => 'Example - basic content',
-            'value' => $key,
-            'group' => 'default',
-        ],
-        'textmedia',
-        'after',
-    );
-
-    // Configure the default backend fields for the content element
-    $GLOBALS['TCA']['tt_content']['types'][$key] = [
-        'showitem' => '
+// Configure the default backend fields for the content element
+$GLOBALS['TCA']['tt_content']['types'][$key] = [
+    'showitem' => '
             --palette--;;headers,
             bodytext,
         ',
-    ];
-});
+];