Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding external participants to a course does not work #1010

Open
maxi-k opened this issue Apr 26, 2023 · 4 comments · May be fixed by #1406
Open

Adding external participants to a course does not work #1010

maxi-k opened this issue Apr 26, 2023 · 4 comments · May be fixed by #1406
Assignees

Comments

@maxi-k
Copy link

maxi-k commented Apr 26, 2023

Describe the bug
As a course admin, I see an option to add external participants to the course on the admin page by entering a name and an email address.
The input placeholder text indicates that it is possible to add external mail addresses here, and that they should receive an invitation mail.
When I test this with one of my private email addresses, I don't receive an email and there's no indication that anything happened.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the admin page of a course you administrate
  2. Scroll down to the "External Participants" section
  3. Add a name and private email address you know exists (I checked multiple providers)
  4. Click "Submit"
  5. Check every spam folder, observe no invitation mail exists
  6. Klick the "Show Invitations" Link in the "External Participants" section; there are no invitations there either

Expected behavior
I expected an invitation mail to arrive at the email account I tested this with, and maybe some kind of data to appear in the 'invitations' section.

Desktop

  • OS: Ubuntu 22.10
  • Browser: Firefox
  • Version: 111

Additional context
I checked the networking tab using the browser inspection view.
This seems to POST form data to /api/course/{cousrseId}/createUserForCourse and always returns 200 OK.

@joschahenningsen joschahenningsen self-assigned this Apr 26, 2023
@karjo24
Copy link
Contributor

karjo24 commented Nov 14, 2024

I'm not able to reproduce this. @joschahenningsen do you know whether you could repro this at the time of self assigning this or not?

@karjo24
Copy link
Contributor

karjo24 commented Nov 14, 2024

Anyways, I'll fix the bug that "show invitation" doesn't actually show anything.

@joschahenningsen joschahenningsen removed their assignment Nov 14, 2024
@joschahenningsen
Copy link
Member

joschahenningsen commented Nov 14, 2024

I cannot recall, I remember having implemented a new email queuing table

Create(context.Context, *model.Email) error
for inviting admins to their lectures, which works reliably. We should use it also for inviting external participants.

@karjo24 karjo24 self-assigned this Nov 14, 2024
@karjo24
Copy link
Contributor

karjo24 commented Nov 14, 2024

We should use it also for inviting external participants.

You already changed the respective functions so external participants are invited via the email queuing table in June of 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants