Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtle error in render_all part 2 #9

Open
dsouth opened this issue Nov 2, 2018 · 1 comment
Open

subtle error in render_all part 2 #9

dsouth opened this issue Nov 2, 2018 · 1 comment

Comments

@dsouth
Copy link

dsouth commented Nov 2, 2018

libtcod.console_blit(con, 0, 0, screen_width, screen_height, 0, 0, 0)

If I'm reading the libtcod Python source correctly this says blit from console con to console root (0). This will work since, at least at this point in time, you con is also the root console. But this won't work if the con is any other console. So this may break if the users try to reuse this with more than one console in the future.

@dsouth
Copy link
Author

dsouth commented Nov 2, 2018

Or maybe that's the intent in that you are drawing to an offscreen console and then blitting to the root console? If so, it was a little bit unclear to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant