Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect normalization for depth network #14

Open
dominikandreas opened this issue Apr 5, 2023 · 0 comments
Open

Incorrect normalization for depth network #14

dominikandreas opened this issue Apr 5, 2023 · 0 comments

Comments

@dominikandreas
Copy link

dominikandreas commented Apr 5, 2023

Hey, just wanted to let you know that the input to the depth network for the odometry evaluation is incorrectly normalized. The depth encoder already includes normalization, so the to_color_normalized function should not be applied to the inputs for the depth network, e.g. as done here
https://github.com/TRI-ML/KP3D/blob/master/kp3d/evaluation/evaluate_keypoint_odometry.py#L71-L83

also note that this function multiplies by the standard deviation instead of dividing by it. this is probably suboptimal, but I guess since it's trained that way, it shouldn't be fixed (at least not for the pretrained keypoint net).

KP3D/kp3d/utils/image.py

Lines 112 to 115 in 3eb9d25

assert len(images.shape) == 4
images -= 0.5
images *= 0.225
return images

using the proper normalization for the depth network slightly improves the results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant