Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train using our own data #13

Open
MajdWardeh opened this issue Feb 26, 2022 · 5 comments
Open

Train using our own data #13

MajdWardeh opened this issue Feb 26, 2022 · 5 comments

Comments

@MajdWardeh
Copy link

MajdWardeh commented Feb 26, 2022

Hi,

Thank you for this amazing paper!
I was wondering if you could provide the code to train the models.
I believe that the best way to prove the real performance of your approach is by letting people train it by themselves.

Thank you,

@RaresAmbrus
Copy link
Contributor

Hi, thanks for the interest! Sadly we have no plans to release the training code, but happy to answer any specific questions about our method.

@MajdWardeh
Copy link
Author

Hi @RaresAmbrus,

I am trying to implement the training part of KP3D. I have a couple of questions that I would be glad if you could help me with.

  1. After estimating the rotation, R, by solving the Orthogonal Procrestous problem, the resulting R could have a det of -1. What do you do to resolve this? do you implement Kabsch algorithm?
  2. For the geometric loss, It's stated that it is applied to the initial set of correspondences (the set obtained with descriptor matching). However, what about the outliers? is there any outlier rejection procedure or is there another rematching step (similar to KP2D)?
  3. For the descriptor loss, What are the positive descriptors associated with the anchor descriptors set? Are they defined by the inliers set coming from solving PnP with RANSAC? Otherwise, how could we find those positive descriptors?

Thank you so much (and for your colleagues) for this great paper!
Kind regards,
Majd Wardeh

@MajdWardeh
Copy link
Author

Hello @RaresAmbrus,

I am sure you are very busy. I would be glad if you could help me clarify the questions above when you have the time.

Kind regards,
Majd

@Cc19245
Copy link

Cc19245 commented Nov 14, 2022

Hello @RaresAmbrus,

I am sure you are very busy. I would be glad if you could help me clarify the questions above when you have the time.

Kind regards, Majd

Hi, Majd! I'm also struggle to reproduce the training code of KP3D. Maybe we can get some communication? My email is [email protected]. Looking forward to you reply!

@RaresAmbrus
Copy link
Contributor

Hi, thanks for the interest and sorry about the slow reply, I'm out of the office and will only get back around the end of Nov. I'll try to take a look at the code. In the meantime, maybe @jiexiong2016 is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants