Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize the setup.sh script #257

Open
sergkudinov opened this issue Mar 3, 2023 · 2 comments
Open

Modularize the setup.sh script #257

sergkudinov opened this issue Mar 3, 2023 · 2 comments

Comments

@sergkudinov
Copy link
Contributor

sergkudinov commented Mar 3, 2023 •
edited
Loading

The script ./script/setup.sh is getting bigger and currently contains functionalities of different types:

  • setup git submodules
  • setup configuration
  • initialization and installation

My suggestion is to split it into multiple files which are imported to the "main" setup script. Such a modular structure is more maintainable, and easier for those who only picks desired parts of it to build a TDP cluster template like us at EDF.
@sergkudinov sergkudinov changed the title Refactor setup.sh script file to smaller files Split setup.sh script file to smaller files Mar 3, 2023
@sergkudinov sergkudinov changed the title Split setup.sh script file to smaller files Modularize the setup.sh script Mar 3, 2023
@sergkudinov
Copy link
Contributor Author

What are your thinking?
@rpignolet

@rpignolet
Copy link
Contributor

Yes good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpignolet @sergkudinov