Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework TDyDriver* into its own data structure and interface #212

Open
jeff-cohere opened this issue Sep 24, 2021 · 0 comments
Open

Rework TDyDriver* into its own data structure and interface #212

jeff-cohere opened this issue Sep 24, 2021 · 0 comments
Labels
cleanup Refactor code enhancement New feature or request

Comments

@jeff-cohere
Copy link
Collaborator

jeff-cohere commented Sep 24, 2021

In recent days, we've been discussing how the TDycore library interface should look to a "client". I think we're converging on a system where you create and configure a dycore object, extract a DM from it, and pass that DM to a solver of your choice to use for your simulation (see PR #211).

We also discussed a higher-level "black box" interface that doesn't require a user to manipulate PETSc's solvers. I think te TDyDriver functions represent the beginning of this higher-level interface. However, I'd like to devise a separate data structure called TDyDriver that has its own functions, rather than have the TDy structure handle both the high- and low-level interfaces.

@bishtgautam @ghammond86

@jeff-cohere jeff-cohere added the question Further information is requested label Sep 24, 2021
@jeff-cohere jeff-cohere changed the title Question: do we still need TDyDriver? Rework TDyDriver* into its own data structure and interface Sep 28, 2021
@jeff-cohere jeff-cohere added cleanup Refactor code enhancement New feature or request and removed question Further information is requested labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactor code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant