Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-mute when lagging #3238

Open
YoshiRulz opened this issue May 7, 2022 · 2 comments · May be fixed by #3866
Open

Auto-mute when lagging #3238

YoshiRulz opened this issue May 7, 2022 · 2 comments · May be fixed by #3866
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements Open to design proposals only We're not ready to add this yet, but technical discussion of how it could be added is welcome. Repro: Fixed/added in branch/fork

Comments

@YoshiRulz
Copy link
Member

For example, when frame times exceed 19 ms (< 90% speed for a 60 fps game) for N consecutive frames. Then a similar heuristic would trigger an unmute if frame times go back down.

@YoshiRulz YoshiRulz added Enhancement For feature requests or possible improvements App: EmuHawk Relating to EmuHawk frontend Open to design proposals only We're not ready to add this yet, but technical discussion of how it could be added is welcome. labels May 7, 2022
@Meerkov
Copy link
Contributor

Meerkov commented Sep 4, 2022

It's an interesting idea. I do notice audio stuttering when I play at 54 FPS, but if anything, that warns me that I need to check my settings in order to get back to a proper 60 FPS.

I don't know much about how audio works, but would a more user-friendly answer be to buffer 1 frame of audio, and then stretch the audio for 2 frames worth of time if the next frame isn't ready? This solution sounds much more complicated, but I would assume would provide a better casual gaming experience than having the audio constantly muting/unmuting during variable CPU load.

@YoshiRulz
Copy link
Member Author

I wasn't thinking about casual play when I proposed this. You wouldn't expect frame times to vary much for casual play—as you elude to, a spike in frame times would probably be the result of misconfiguring EmuHawk or of another program hogging resources. I was mainly concerned about RAM Search hurting my ears while glitch hunting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements Open to design proposals only We're not ready to add this yet, but technical discussion of how it could be added is welcome. Repro: Fixed/added in branch/fork
Projects
None yet
2 participants