Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/WG-402: Asset feature image download; Various Fixes #331

Merged
merged 11 commits into from
Feb 18, 2025
Merged

task/WG-402: Asset feature image download; Various Fixes #331

merged 11 commits into from
Feb 18, 2025

Conversation

rstijerina
Copy link
Contributor

@rstijerina rstijerina commented Feb 18, 2025 •
edited
Loading

Overview:

  • Adds download to asset feature images
  • fixes react router baseurl
  • fix export to geojson button
  • fix asset panel size when feature tree collapses
  • do not render import and edit buttons when in public view
  • add tooltip to "view in private map" button

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Open asset preview and click download. Locally, it won't download since the origin is different, but it should when in production, or if your api url is local geoapi

sophia-massie
sophia-massie approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rstijerina rstijerina changed the title task/WG-402: Asset feature image download task/WG-402: Asset feature image download; Various Fixes Feb 18, 2025
@rstijerina rstijerina merged commit 2d6a097 into main Feb 18, 2025
5 checks passed
@rstijerina rstijerina deleted the task/WG-402--asset-image-download branch February 18, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

@nathanfranklin nathanfranklin Awaiting requested review from nathanfranklin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstijerina @sophia-massie