Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of --preout and --postout #175

Open
JohnHadish opened this issue Jul 10, 2020 · 1 comment
Open

Consistency of --preout and --postout #175

JohnHadish opened this issue Jul 10, 2020 · 1 comment

Comments

@JohnHadish
Copy link
Collaborator

JohnHadish commented Jul 10, 2020

When kinc help run similarity is run, preout and postout default value to true (all lower case)

--preout <value>
Value Type: Boolean
Default Value: true
Whether to remove pre-clustering outliers.

--postout <value>
Value Type: Boolean
Default Value: true
Whether to remove post-clustering outliers.

In the example documentation, they are set to TRUE (all uppercase)

kinc run similarity \
   --input "PRJNA301554.slim.GEM.log2.emx" \
   --ccm "PRJNA301554.slim.GEM.log2.ccm" \
   --cmx "PRJNA301554.slim.GEM.log2.cmx" \
   --clusmethod "gmm" \
   --corrmethod "spearman" \
   --minexpr -inf \
   --minsamp 25 \
   --minclus 1 \
   --maxclus 5 \
   --crit "ICL" \
   --preout TRUE \
   --postout TRUE \
   --mincorr 0 \
   --maxcorr 1 

In the c++ standard, true is a bool where as TRUE is not defined.

@bentsherman
Copy link
Member

C++ types aren't relevant to how command-line arguments are parsed, as they are all strings. You'd have to check the ACE code that handles argument parsing, but I believe ACE supports both "true" and "TRUE" for boolean arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants