Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExamplePackage Makefile and SynoBuildConf/install are invalid #3

Open
pjdubya opened this issue Jun 5, 2024 · 1 comment · May be fixed by #4
Open

ExamplePackage Makefile and SynoBuildConf/install are invalid #3

pjdubya opened this issue Jun 5, 2024 · 1 comment · May be fixed by #4

Comments

@pjdubya
Copy link

pjdubya commented Jun 5, 2024

Makefile attempts to execute GenerateModuleFiles.php which does not exist in this repo or in https://github.com/SynologyOpenSource/pkgscripts-ng . The website page https://help.synology.com/developer-guide/getting_started/first_package.html is what asks users to use this ExamplePackage in the first place, but then on that page it uses a different Makefile (without telling the user that it is different and they should modify their local version).

Likewise the create_package_tgz() in SynoBuildConf/install differs from what is on that page, and as it is, the SynoBuildConf/install is invalid, throwing:

make: *** No rule to make target 'packageinstall'. Stop.
@pjdubya pjdubya linked a pull request Jun 5, 2024 that will close this issue
Open
@yi10235512
Copy link
Collaborator

Hi @pjdubya,

Thank you for your feedback regarding the use of SynologyOpenSource.

In DSM 7.2.2, we have introduced a new way that allows users to create DSM Package Applications using the Vue.js framework. Additionally, we have provided a new 7.2 toolkit, along with necessary tools available at here. The missing GenerateModuleFiles.php file is now included in that branch.

We apologize for any confusion caused and will update the documentation promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix broken makefile and install in ExamplePackage pjdubya/ExamplePackages
2 participants
@pjdubya @yi10235512