Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bincode.varint is redundant and not well named #260

Open
Rexicon226 opened this issue Aug 29, 2024 · 0 comments
Open

bincode.varint is redundant and not well named #260

Rexicon226 opened this issue Aug 29, 2024 · 0 comments

Comments

@Rexicon226
Copy link
Contributor

https://github.com/Syndica/sig/blob/870c1efba8fc1e969fdff47a8b97d5decd31c3b0/src/bincode/varint.zig

This file and type are badly named since:

  1. It isn't actually defining the bincode varint, defined here: https://github.com/bincode-org/bincode/blob/trunk/docs%2Fspec.md#varintencoding
  2. This is re-implementing the stdlib functions, std.leb.readUleb128 and std.leb.writeUleb128.

I believe @InKryption wanted to do a clean-up of the bincode code, so this is a tracking issue as to not forget :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sig
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rexicon226