Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: replace all uses of std.time.milliTimestamp as a seed with parameterized seeds or RNGs #176

Open
InKryption opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@InKryption
Copy link
Contributor

We should replace all uses of std.time.milliTimestamp as a seed that aren't obviously at the highest level of code, with a std.Random interface parameter, or a pointer to a concrete PRNG implementation if specific random behavior is desired/required.

This would facilitate testing by making behavior deterministic, and as well allow us to more easily identify when we could use a better source of entropy than timestamps, which are a poor source.

Originally posted by @InKryption in #157 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants