Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] npm run make not working when making RPM #14

Closed
aldenparker opened this issue Feb 5, 2025 · 2 comments
Closed

[Bug] npm run make not working when making RPM #14

aldenparker opened this issue Feb 5, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@aldenparker
Copy link
Contributor

Summary:

When npx electron-forge make --targets rpm (the equivalent of the make script for rpm) is run, the build does not complete with this error:
cp: cannot stat 'usr/*': No such file or directory

Steps to Reproduce:

  1. cd client
  2. npx electron-forge make --targets rpm

Expected Behavior:

RPM package gets successfully built.

Actual Behavior:

Error regarding thew usr directory.

Environment Details:

  • Node version: v22.11.0
  • Electron version: 34.0.1
@aldenparker aldenparker added the bug Something isn't working label Feb 5, 2025
@aldenparker aldenparker self-assigned this Feb 5, 2025
@aldenparker
Copy link
Contributor Author

Seems to be an error with a forge dependency for Fedora 41. Fix mentioned in this issue works, however every node module install would wipe local changes.

@aldenparker
Copy link
Contributor Author

Patch now included in .github/patches folder. Run patch ./client/node_modules/electron-installer-redhat/resources/spec.ejs < ./.github/patches/spec.ejs.patch from the root directory of the project to patch locally, github workflow works without this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant