Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory retain cycle #179

Open
otymartin opened this issue Apr 5, 2017 · 1 comment
Open

Memory retain cycle #179

otymartin opened this issue Apr 5, 2017 · 1 comment

Comments

@otymartin
Copy link

otymartin commented Apr 5, 2017

@jpotts18
I'm trying to debug leaks, none of my VC's implementing this library are calling deinit so I was wondering if it has to do with the way the delegate validator delegate is set. I may be wrong but it appears that this holds a strong reference to my VC?
self.validator.validate(self)

Also validation delegate is not declare as a class protocol so no weak references can be made to it I assume?

public protocol ValidationDelegate {
    /**
     This method will be called on delegate object when validation is successful.
     
     - returns: No return value.
     */
    func validationSuccessful()
    /**
     This method will be called on delegate object when validation fails.
     
     - returns: No return value.
     */
    func validationFailed(_ errors: [(Validatable, ValidationError)])
}
@jpotts18
Copy link
Collaborator

I'm not going to lie this project took off and I'm pretty overwhelmed by it. I no longer actively code in Swift and I need help from more contributors in order to keep this project relevant. I'd like to find someone to transition as lead maintainer or help this codebase find a happy home with a company.

The codebase for this project is relatively small and focused project for who is looking to contribute. It does one thing, and does it pretty well. It has pretty high test coverage and good adoption. I think my ideal maintainer / contributor would work for a company that actively uses SwiftValidator in their production application.

If you're interested in helping out please comment on #204

@jpotts18 jpotts18 reopened this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants