Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider simplifying ExternalApp structure #35

Open
Mazyod opened this issue Jan 6, 2016 · 6 comments
Open

Consider simplifying ExternalApp structure #35

Mazyod opened this issue Jan 6, 2016 · 6 comments

Comments

@Mazyod
Copy link
Member

Mazyod commented Jan 6, 2016

Having added applications inherit ExternalApplication gives us a lot of flexibility, but I am starting to question the need for such a flexible design. Perhaps making it a simple struct instance would reduce all the boilerplate code written for the added apps... Need to investigate.

@Mazyod Mazyod added this to the v2.0.0 milestone Jan 6, 2016
@Maryom
Copy link
Contributor

Maryom commented Jan 6, 2016

This looks great, I have a question we used ExternalApplication instead of calling openURL because of this 👇🏼
https://twitter.com/nicklockwood/status/595347585747001344

@Mazyod
Copy link
Member Author

Mazyod commented Jan 6, 2016

nah, this is just a refactor to organize the library API

@Maryom
Copy link
Contributor

Maryom commented Jul 7, 2016

Salam,

I think this will help, do you agree?

screen shot 2016-07-07 at 11 23 47 am

@Mazyod
Copy link
Member Author

Mazyod commented Jul 12, 2016

This is real nice, we'll need to support this when it comes out, yes.

@Mazyod Mazyod modified the milestones: v3.0.0, v2.0.0 Sep 20, 2016
@Maryom
Copy link
Contributor

Maryom commented Sep 21, 2016

Salaam,

I need to know still we need to support iOS 9 ? because I think it's better to use iOS 10 new method:
open func open(_ url: URL, options: [String : Any] = [:], completionHandler completion: (@escaping (Bool) -> Swift.Void)? = nil)

There is a solution if we need to support iOS 9 but I just need to know to save some lines of code.

@Mazyod
Copy link
Member Author

Mazyod commented Sep 21, 2016

This is a different feature, so I created a new issue for that here: #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants