Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING keyword in commit messages not being used to trigger a major release #78

Open
JossWhittle opened this issue Oct 9, 2023 · 3 comments
Open

BREAKING keyword in commit messages not being used to trigger a major release #78

JossWhittle opened this issue Oct 9, 2023 · 3 comments
Assignees
@rdash99
Labels
bug Something isn't working

Comments

@JossWhittle
Copy link
Member

feat: BREAKING change to foo bar

Should trigger a major release but doesn't.
@JossWhittle JossWhittle added the bug Something isn't working label Oct 9, 2023
@rdash99
Copy link
Contributor

rdash99 commented Oct 10, 2023

workflows/.github/workflows/version.yaml

Line 10 in 958100e

release-rules:
BREAKING doesn't appear to be in the release rules

@rdash99 rdash99 self-assigned this Oct 10, 2023
@rdash99
Copy link
Contributor

rdash99 commented Oct 10, 2023

BREAKING CHANGE: The graphiteWidth option has been removed. The default graphite width of 10mm is always used for performance reasons. Major Breaking Release (Note that the BREAKING CHANGE: token must be in the footer of the commit)

from

@JossWhittle
Copy link
Member Author

https://github.com/SwanseaUniversityMedical/NRDA-Stack-Helm/actions/runs/6467842933
https://github.com/SwanseaUniversityMedical/NRDA-Stack-Helm/commit/012fd1ee838612a41917e1e902f0311fc11ab838

Ignore that it failed because of harbor, but it didn't respect BREAKING CHANGE: blah in the commit footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdash99 rdash99

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

fix/breaking-keyword-in-commit-messages-not-being-used-to-trigger-a-major-release SwanseaUniversityMedical/workflows
2 participants
@JossWhittle @rdash99