Always return "ArchiveProvider" in case "downloadAsCbz" is enabled #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too sure about this, I would like to keep support for old folder downloads, and only use cbz when creating new downloads and using cbz archives. If this is merged we wouldn't be able to use old folder downloads, and people would have to re-download everything. Is it possible to download to a temporary folder instead and move the folder/compress it when its finished? |
Due to reusing the "FolderProvider" to download a chapter as a cbz file, a normal chapter download folder was created. In case the download was aborted before the cbz file got created and the folder deleted, the next time the chapter got downloaded, the wrong "FileProvider" was selected, causing the chapter not to get downloaded as a cbz file.
schroda
force-pushed
the
fix/chapter_download_helper_selecting_incorrect_file_provider
branch
from
868fc24
to
3868d41
Compare
|
makes sense, did not think about that use case the chapter now gets downloaded in a temp folder and depending on the file provider it gets either saved as a normal folder or cbz file in the actual download location |
Syer10
approved these changes
Aug 28, 2023
schroda
deleted the
fix/chapter_download_helper_selecting_incorrect_file_provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to reusing the "FolderProvider" to download a chapter as a cbz file, a normal chapter download folder was created.
In case the download was aborted before the cbz file got created and the folder deleted, the next time the chapter got downloaded, the wrong "FileProvider" was selected, causing the chapter not to get downloaded as a cbz file.
fixes #669