Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make entry names updatable #1002

Closed
xdeiimoss opened this issue Aug 2, 2024 · 3 comments · Fixed by #1115
Closed

[Feature Request] Make entry names updatable #1002

xdeiimoss opened this issue Aug 2, 2024 · 3 comments · Fixed by #1115
Labels
enhancement New feature or request

Comments

@xdeiimoss
Copy link

What feature should be added to Suwayomi?

Currently, entry names aren't updatable. If there's any change on the name of the entry on the website itself or something that modifies it in the extension, it doesn't change the name when updating the entry.

Why/Project's Benefit/Existing Problem

Some extensions have an option to remove things from the title (example: mangago after the latest update). The changes was made so it gets easier to migrate entries and track entries because it removes things like (Official) from entry names. Currently, those changes aren't working on Suwayomi.

@xdeiimoss xdeiimoss added the enhancement New feature or request label Aug 2, 2024
@Syer10
Copy link
Collaborator

Syer10 commented Aug 2, 2024

The title does get updated, but only if there manga has no downloads or the downloads rename succeeds.

if (sManga.title != mangaEntry[MangaTable.title]) {
val canUpdateTitle = updateMangaDownloadDir(mangaId, sManga.title)
if (canUpdateTitle) {
it[MangaTable.title] = sManga.title
}
}

@Syer10
Copy link
Collaborator

Syer10 commented Aug 2, 2024

Huh, actually, it seems we don't implement title copying inside the SManga, that needs to be fixed

@aoba-seragakii
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants