-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate_protocols seems to be gone from 0.5 #27
Comments
I don't know how it wouldn't be still required. |
I think I've run into the same problem, trying to use the plugin results in rebar complaining |
If anyone has the time to revert this change and create a PR I can merge it and make a release. |
I removed them because in my test projects they work for me without them, but if it does not work for you I recover them. |
@Supersonido the protocols are consolidated when building a release in your test projects? Or the project can run in a shell? I don't see how you get consolidated protocols without this hook. |
It works for me on both. But I repeat, if you want I put them back. I have no problem. |
Maybe there is miscommunication where I assume the failure was not getting consolidated protocols when it was instead simply build failure because the hook doesn't exist. If it works then there is no need to add the hook back and it should instead be removed from the readme. I think I have a test project I can go check with in a minute. But if anyone else on this thread can confirm if they get consolidated protocols then we can simply get the readme updated and let people know to remove the hook. |
With just the Is there an example project anywhere that shows how to do it right? |
The first error you get is likely to be bypassed if you use the master version of rebar3. We should cut a release soon. |
Argh, yes, we must cut a new release. |
@Supersonido can you clarify that protocols are consolidated? I'll open a PR to remove the hook from the readme if this is the case. |
Hello, Using rebar3 from master branch and rebar_mix 0.5.0 I got this:
I'm just trying to update the `benchee_erlang_try: https://github.com/joaohf/benchee_erlang_try/tree/rebar_mix Full output as follows:
|
Either the hook must be removed from the config or use an older version of |
I brought this issue up at the Build and Packaging WG and Jose says that while it is possible you'll get the right full consolidation without the hook it is a safer bet if we have it. So it does need to be added back. |
ok, i'll added back after lunch (UTC+2 time) |
@Supersonido any update on this? |
It's on develop branch. If someone a part of me could test it would be great |
@Supersonido it at least builds a project fine now even with the hook defined (when using rebar3 from git or the nightly release). So it would be good if you could publish a new version and we will get a new release of rebar3 out. I still need to do more checking on the actual protocol stuff, I thought there used to be a directory in a release generated that had all the consolidated protocol in it and I'm not seeing that, but I may be misremembering. |
Awesome, let's create a new release. |
Hello, Not sure if I need to setup the compile hooks or not. But here is my output when I tried With the hook script
Without hook
|
In 9122f07 you have removed
rebar_mix_hook
which provides the documentedconsolidate_protocols
hook. Is that hook not needed anymore or was the removal accidental?The text was updated successfully, but these errors were encountered: