@@ -22,14 +22,13 @@ def setup
22
22
23
23
def test_creates_new_user_if_not_existing
24
24
assert_difference "User.count" , 1 do
25
- ::Users ::OmniauthUpserter . new ( @auth ) . call
25
+ @returned_user = ::Users ::OmniauthUpserter . new ( @auth ) . call
26
26
end
27
27
28
- user = User . find_by ( uid : @auth . uid )
29
- assert_equal "github" , user . provider
30
- assert_equal "12345" , user . uid
31
- assert_equal "testuser" , user . handle
32
- assert_equal "[email protected] " , user . email
28
+ assert_equal "github" , @returned_user . provider
29
+ assert_equal "12345" , @returned_user . uid
30
+ assert_equal "testuser" , @returned_user . handle
31
+ assert_equal "[email protected] " , @returned_user . email
33
32
end
34
33
35
34
def test_finds_existing_user_if_already_exists
@@ -42,26 +41,26 @@ def test_finds_existing_user_if_already_exists
42
41
)
43
42
44
43
assert_no_difference "User.count" do
45
- ::Users ::OmniauthUpserter . new ( @auth ) . call
44
+ @returned_user = ::Users ::OmniauthUpserter . new ( @auth ) . call
46
45
end
47
46
48
- user = User . find_by ( uid : @auth . uid )
49
- assert_equal existing_user . id , user . id
47
+ assert_equal existing_user . id , @returned_user . id
50
48
end
51
49
52
50
def test_enrolls_user_from_organization_queues
53
- ::Users ::OmniauthUpserter . new ( @auth ) . call
54
- user = User . find_by ( uid : @auth . uid )
51
+ @returned_user = ::Users ::OmniauthUpserter . new ( @auth ) . call
55
52
56
- assert @organization . reload . user_queue . exclude? ( user . handle )
57
- assert OrganizationUser . exists? ( organization : @organization , user : user )
53
+ assert @organization . reload . user_queue . exclude? ( @returned_user . handle )
54
+ assert OrganizationUser . exists? ( organization : @organization , user : @returned_user )
58
55
end
59
56
60
57
def test_does_not_fail_when_handle_not_in_queue
61
58
@organization . update! ( user_queue : [ ] )
62
59
63
60
assert_nothing_raised do
64
- ::Users ::OmniauthUpserter . new ( @auth ) . call
61
+ @returned_user = ::Users ::OmniauthUpserter . new ( @auth ) . call
65
62
end
63
+
64
+ assert @returned_user . is_a? ( User )
66
65
end
67
66
end
0 commit comments