Fix #399: UI changes for optional content #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the common consumption package.
|
hii @rajeevsathish @princegupta1131 , |
Saurabhbalke
changed the base branch from
master
to
v14-UI-angular-material-migration
|
Kudos, SonarCloud Quality Gate passed!
|
princegupta1131
approved these changes
Sep 6, 2023
| @@ -163,7 +166,8 @@ <h4 *ngIf="bestScoreLabel" class="sbchapter__item__score pr-8 ml-auto" title="{{ | |||
| </i> | |||
| <img [src]="fallbackImg" width="32" height="32" *ngIf="!content?.appIcon" alt="image" #img /> | |||
| </div> | |||
| <div >{{content?.name}}</div> | |||
| <div mat-line>{{content?.relationalMetadata?.optional? "Addition Material: ":""}}{{content?.name}}</div> | |||
There was a problem hiding this comment.
@Saurabhbalke why u have added this
{{content?.relationalMetadata?.optional? "Addition Material: ":""}}{{content?.name}}
two time {{}}why we can use like this {{content?.relationalMetadata?.optional ? "Addition Material: " + content?.name : content?.name}}
There was a problem hiding this comment.
hi @princegupta1131
added req changes, Thanks !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
Proof that changes are correct