-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve linux support (new launcher) #1848
base: master
Are you sure you want to change the base?
Conversation
cfb2938
to
dc11b8b
Compare
49cf07d
to
bbfcd47
Compare
With that, we present to you the Cross-Platform launcher. Have fun reviewing this 🌚 |
I have just tested this build on Linux, it does not support server save files from earlier versions or launch on Linux. While the new launch looks and feels great it fails to address the original issue of Linux support. The current version of the launcher is more functional on Linux, however, it fails to detect a running Steam instance so it doesn't launch the game. If we just fixed the code for detecting Steam it should let us avoid rewriting the entire launcher. |
Nitrox v1.8.0.0 is not meant to support older save files since there were major changes made to the build system. |
… instance is started
FileSystemWatcher can cause this race-condition with a manual insert. So the manual insert was removed.
Co-authored-by: dartasen <[email protected]>
XAML Styler plugin auto formatted on save but there's a bug here where it formats selector syntax too...
Fixed using ScrollViewer with DockerPanel&Grid combo.
The hyperlink text wasn't aligned for some reason and I thought it would look better if it was a button instead of a link. That being said, it looks a bit weird to have there.
There was a weird styling issue that I noticed where the actual "text" block area was centered within the textbox, making the cursor not change unless you hovered over it and also making selecting text a bit less convenient. This commit fixes that, though it would've been easier to fix had it not been for the DockPanel#PART_InnerDockPanel element refusing to stay at 0 margin and instead continuing to use the TemplateBinding padding. About 2.5 hours of work had to be put in and many hoops had to be jumped through to solve this issue :(
There is still an issue with initial foreground coloring, mentioned by the "TODO" comment in the code.
Skipped over prior color tags to the last applicable.
Co-Authored-By: Meas <[email protected]>
dotnet build
on dotnet SDK 8+NitroxLauncher
to play Subnautica with Nitrox.NitroxLauncher
)This PR includes solution-wide changes to multi-target for .net 9 (server, launcher) and .net 4.7.2 (game client), allowing benefits of modern .net where possible.
Closes #988
Resources to assist with implementation